[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: design discusion: using QtXmlStreamReader instead of KoXmlReader
From:       Jos van den Oever <jos.van.den.oever () kogmbh ! com>
Date:       2010-08-10 19:04:55
Message-ID: 201008110022.55671.jos.van.den.oever () kogmbh ! com
[Download RAW message or body]

On Wednesday, August 11, 2010 00:18:15 am Ariya Hidayat wrote:
> > (And though I think KoXmlReader is _very_ impressive, I think it will be
> > good for maintainability if we can drop it. It's very hairy code full of
> > warnings for the unaware.)
> 
> I take the blame :)
> 
> Maybe I shall refactor it, e.g. taking out the compression part and
> separate it? It was one-file-to-rule-them-all for the sake of getting
> it to work, but as of today obviously it can use some clean up.

Splitting it up a bit would be a good idea. But please wait until my latest 
patch is reviewed [1].

I think it's impressive code too btw.

[1] http://reviewboard.kde.org/r/4967/

-- 
Jos van den Oever, software architect
+49 391 25 19 15 53
http://kogmbh.com/legal/
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]