[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Allow painting text outside the shape
From: "Suresh Chande" <suresh.chande () nokia ! com>
Date: 2010-08-10 18:50:30
Message-ID: 20100810185030.1792.73833 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-08-03 12:07:37, Thomas Zander wrote:
> > I must say I was rather fond of the simplicity of a shape having a size=
and it its content is limited to that. This makes repainting faster, it ma=
kes things consistent with other frameworks and predictable/understandable.=
I think going away from that by introducing the possibility to ignore the =
actual size by having a second size is not something that I like very much.
> > =
> > Negative margins have never worked in KWord, it has in its 12=C2=BD yer=
as never given us a significant amount of bugreports and I feel its not a f=
eature I value enough to break the flake design.
> > I was under the impression I closed all bugreports for this on bugzilla=
as 'wontfix' if I missed one I apologize for causing you to work on this w=
hile I never intended KWord to go in that direction.
> > =
> > One solution may be that we make the auto-generated frames in KWord be =
full page-width and use the shape inset to represent the kword-page margins=
. But this solution feels like we are contorting flake for a misfeature tha=
t we can do without just fine.
> > =
> > As an extended rationale for why flake should not go in this direction;=
Flake is bigger than KWord or KOffice. It will be used by other applicati=
ons that want an ODF rendering engine and it will be very hard to explain t=
hat the shape size is not enough for a canvas implementor to look at when d=
etermining how to position the (text) shape in 3rd party applications canva=
s'.
> > =
> > So, bottom line; please discard this review for the reasons given above.
Please re-consider your decision choice on this Thomas. We have some real w=
orld documents we are facing issues related to this. This would be good to =
get Kword to work please propose a way to address this issue. This is relev=
ant for us to see work in KOffice. How come you have not faced such docume=
nts in 12.5 years ? I guess we are now heading towards end user readiness a=
nd you should consider real world documents to mature KOffice and get this =
issue fixed. Lets find a solution to this one.
- Suresh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4861/#review6768
-----------------------------------------------------------
On 2010-08-03 11:31:02, Casper Boemann wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4861/
> -----------------------------------------------------------
> =
> (Updated 2010-08-03 11:31:02)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> When you have negative indents you want to be able to paint text outside =
the frame of the textshape.
> =
> This patch accomplishes that.
> =
> It also changes the way Rulers work regarding active ranges. First it now=
has the notion of an override range which the rulermanager gets from resou=
rcemanager.
> This way the tools are now responsible for setting the (override) active =
range.
> The default active range is still set by the apps, (and kword now also de=
faults to the entire paper like kpresenter)
> =
> As to the draw outside i've introduced an outlineRect() method similar to=
outline() but just a rect rather than a path.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/kword/part/KWGui.cpp 1158585 =
> trunk/koffice/kword/part/tests/TestDocumentLayout.cpp 1158585 =
> trunk/koffice/libs/flake/KoResourceManager.h 1158585 =
> trunk/koffice/libs/flake/KoShape.h 1158585 =
> trunk/koffice/libs/flake/KoShape.cpp 1158585 =
> trunk/koffice/libs/kotext/KoTextDocumentLayout.h 1158585 =
> trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp 1158585 =
> trunk/koffice/libs/main/KoRuler.h 1158585 =
> trunk/koffice/libs/main/KoRuler.cpp 1158585 =
> trunk/koffice/libs/main/KoRulerController.cpp 1158585 =
> trunk/koffice/libs/main/KoRuler_p.h 1158585 =
> trunk/koffice/plugins/textshape/Layout.h 1158585 =
> trunk/koffice/plugins/textshape/Layout.cpp 1158585 =
> trunk/koffice/plugins/textshape/TextShape.h 1158585 =
> trunk/koffice/plugins/textshape/TextShape.cpp 1158585 =
> trunk/koffice/plugins/textshape/TextTool.cpp 1158585 =
> trunk/koffice/plugins/textshape/tests/TestDocumentLayout.cpp 1158585 =
> =
> Diff: http://reviewboard.kde.org/r/4861/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Casper
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4861/">http://reviewboard.kde.org/r/4861/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 3rd, 2010, 12:07 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I must say I was rather fond of the simplicity of a shape having a size \
and it its content is limited to that. This makes repainting faster, it makes things \
consistent with other frameworks and predictable/understandable. I think going away \
from that by introducing the possibility to ignore the actual size by having a second \
size is not something that I like very much.
Negative margins have never worked in KWord, it has in its 12 ½ yeras never given us \
a significant amount of bugreports and I feel its not a feature I value enough to \
break the flake design. I was under the impression I closed all bugreports for this \
on bugzilla as 'wontfix' if I missed one I apologize for causing you to work \
on this while I never intended KWord to go in that direction.
One solution may be that we make the auto-generated frames in KWord be full \
page-width and use the shape inset to represent the kword-page margins. But this \
solution feels like we are contorting flake for a misfeature that we can do without \
just fine.
As an extended rationale for why flake should not go in this direction; Flake is \
bigger than KWord or KOffice. It will be used by other applications that want an ODF \
rendering engine and it will be very hard to explain that the shape size is not \
enough for a canvas implementor to look at when determining how to position the \
(text) shape in 3rd party applications canvas'.
So, bottom line; please discard this review for the reasons given above.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please re-consider your \
decision choice on this Thomas. We have some real world documents we are facing \
issues related to this. This would be good to get Kword to work please propose a way \
to address this issue. This is relevant for us to see work in KOffice. How come you \
have not faced such documents in 12.5 years ? I guess we are now heading towards end \
user readiness and you should consider real world documents to mature KOffice and get \
this issue fixed. Lets find a solution to this one.</pre> <br />
<p>- Suresh</p>
<br />
<p>On August 3rd, 2010, 11:31 a.m., Casper Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Casper Boemann.</div>
<p style="color: grey;"><i>Updated 2010-08-03 11:31:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When you have negative indents you want to be able to paint text outside \
the frame of the textshape.
This patch accomplishes that.
It also changes the way Rulers work regarding active ranges. First it now has the \
notion of an override range which the rulermanager gets from resourcemanager. This \
way the tools are now responsible for setting the (override) active range. The \
default active range is still set by the apps, (and kword now also defaults to the \
entire paper like kpresenter)
As to the draw outside i've introduced an outlineRect() method similar to \
outline() but just a rect rather than a path.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/kword/part/KWGui.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/kword/part/tests/TestDocumentLayout.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/flake/KoResourceManager.h <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/flake/KoShape.h <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/flake/KoShape.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/kotext/KoTextDocumentLayout.h <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/main/KoRuler.h <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/main/KoRuler.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/main/KoRulerController.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/libs/main/KoRuler_p.h <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/plugins/textshape/Layout.h <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/plugins/textshape/TextShape.h <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/plugins/textshape/TextShape.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/plugins/textshape/TextTool.cpp <span style="color: \
grey">(1158585)</span></li>
<li>trunk/koffice/plugins/textshape/tests/TestDocumentLayout.cpp <span style="color: \
grey">(1158585)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4861/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic