'Re: Review Request: KSpread: Checks if the Tool Options widget is'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: KSpread: Checks if the Tool Options widget is
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2010-08-09 17:56:14
Message-ID: 20100809175614.6052.54530 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4940/#review6917
-----------------------------------------------------------

Ship it!

The change itself looks fine, I just wonder why it is needed? Wasn't freoff=
ice going to reimplement createEditor entirely anyway, as the current cell =
editor didn't work in Maemo for some reason? Or did you somehow manage to m=
ake it work after all?

- Marijn

On 2010-08-09 05:19:34, Gopalakrishna Bhat wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4940/
> -----------------------------------------------------------
> =

> (Updated 2010-08-09 05:19:34)
> =

> =

> Review request for KOffice and Marijn Kruisselbrink.
> =

> =

> Summary
> -------
> =

> KSpread: Checks if the Tool Options widget is created before connecting t=
o it. It was crashing when called from FreOffice.
> =

> =

> Diffs
> -----
> =

>   /trunk/koffice/kspread/ui/CellToolBase.cpp 1160852 =

> =

> Diff: http://reviewboard.kde.org/r/4940/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Gopalakrishna
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4940/">http://reviewboard.kde.org/r/4940/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change itself looks \
fine, I just wonder why it is needed? Wasn&#39;t freoffice going to reimplement \
createEditor entirely anyway, as the current cell editor didn&#39;t work in Maemo for \
some reason? Or did you somehow manage to make it work after all?</pre>  <br />

<p>- Marijn</p>

<br />
<p>On August 9th, 2010, 5:19 a.m., Gopalakrishna Bhat wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice and Marijn Kruisselbrink.</div>
<div>By Gopalakrishna Bhat.</div>

<p style="color: grey;"><i>Updated 2010-08-09 05:19:34</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KSpread: Checks if the Tool Options widget is created before connecting \
to it. It was crashing when called from FreOffice.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/kspread/ui/CellToolBase.cpp <span style="color: \
grey">(1160852)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4940/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 