[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    FW: koffice/kword/part/frames
From:       Hanzes Matus <matus.hanzes () ixonos ! com>
Date:       2010-08-10 14:28:39
Message-ID: 4F8440E481123C40BD41EAC2D6317457027B27 () HKIMAIL01 ! ixonos ! local
[Download RAW message or body]



-----Original Message-----
From: Hanzes Matus 
Sent: 10. augusta 2010 16:13
To: 'zander@kde.org'
Subject: RE: koffice/kword/part/frames

Sorry for not consulting you but it was needed now and I don't want to discuss it on \
review board for a week.

And you are right with tests, but I don't have unit tests in mind but tests of kword \
as a whole.

I think the comparison of page screen shots is needed.
I thing that every pixel is important and this will solve regression problems.

Once more I am sorry but you didn't discuss with me either.

> -----Original Message-----
> From: zander@kde.org [mailto:zander@kde.org]
> Sent: 10. augusta 2010 15:35
> To: Hanzes Matus
> Subject: Re: koffice/kword/part/frames
> 
> On Tuesday 10. August 2010 14.33.53 Matus Hanzes wrote:
> > Revert commit 1158423 because it causes severe regressions for
> background
> > images.  Discussed with ingwa.
> 
> Why are you discussing it with Inge? Thats like discussing it with 
> your neighbor. Both of them have no knowledge of KWord internals.
> 
> I think it would work a lot better if you work together which means 
> communicate with the other people working on KWord. Like me, for 
> example.
> 
> I think I mentioned this before, but I have no problem stating it 
> again.
> Writing new features in KWord are obligatory accompanied with unit 
> tests. If they are missing then stuff will regress.
> Your solution to revert any fixes you don't understand will just stop 
> progress.
> If I did that every time someone broke something this would be a 
> really really slow moving project.
> 
> So, write unit tests and you will be sure your code will keep working.
> 
> --
> Thomas Zander

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]