[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: msword-odf filter: support for bookmarks inside
From: "Matus Uzak" <matus.uzak () ixonos ! com>
Date: 2010-08-03 14:43:11
Message-ID: 20100803144311.20548.54051 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4755/
-----------------------------------------------------------
(Updated 2010-08-03 14:43:10.633297)
Review request for KOffice.
Changes
-------
Patch additions:
* Added support for nested fields! The previous path which added support f=
or bookmarks in field result started to cause crashes because of nested fie=
lds. =
* Processing of fields has been checked for bookmark support and rewritten =
a bit. =
* The field result of a HYPERLINK field is now placed into the <text:span> =
element with the correct style applied.
=
Summary
-------
A field as described by [1] consist of field instructions and the field res=
ult. While processing a .doc file a bookmark may refer to text of the fiel=
d result.
Patch description:
* processing of the hyperlink field has been rewritten
* added support for bookmarks in the field result of hyperlinks
* added support for hyperlinks having a field result referring to a floatin=
g or inline picture
* removals in processing of the pageref field were consulted with Jean-Nico=
las Artaud
TODO:
* the field result has to be placed into the <text:span> element with the c=
orrect style applied
* there seems to be no support for the <draw:a> element
* processing of all other fields has to be checked for bookmarks support
=
[1] [MS-DOC] Word Binary File Format (.doc) Structure Specification =
Diffs (updated)
-----
trunk/koffice/filters/kword/msword-odf/paragraph.h 1158193 =
trunk/koffice/filters/kword/msword-odf/paragraph.cpp 1158193 =
trunk/koffice/filters/kword/msword-odf/texthandler.h 1158193 =
trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1158193 =
Diff: http://reviewboard.kde.org/r/4755/diff
Testing
-------
mw00_hyperlink_picture.doc
mw00_hyperlink_url.doc
mw00_table_with_hyperlinks.doc
mw03_hyperlink_picture.doc
mw03_hyperlink_url.doc
mw03_table_with_hyper_links.doc
Thanks,
Matus
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4755/">http://reviewboard.kde.org/r/4755/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Matus Uzak.</div>
<p style="color: grey;"><i>Updated 2010-08-03 14:43:10.633297</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch additions:
* Added support for nested fields! The previous path which added support for \
bookmarks in field result started to cause crashes because of nested \
fields.
* Processing of fields has been checked for bookmark support and rewritten a bit.
* The field result of a HYPERLINK field is now placed into the <text:span> \
element with the correct style applied.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A field as described by [1] consist of field instructions and the field \
result. While processing a .doc file a bookmark may refer to text of the field \
result.
Patch description:
* processing of the hyperlink field has been rewritten
* added support for bookmarks in the field result of hyperlinks
* added support for hyperlinks having a field result referring to a floating or \
inline picture
* removals in processing of the pageref field were consulted with Jean-Nicolas Artaud
TODO:
* the field result has to be placed into the <text:span> element with the \
correct style applied
* there seems to be no support for the <draw:a> element
* processing of all other fields has to be checked for bookmarks support
[1] [MS-DOC] Word Binary File Format (.doc) Structure Specification </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">mw00_hyperlink_picture.doc mw00_hyperlink_url.doc
mw00_table_with_hyperlinks.doc
mw03_hyperlink_picture.doc
mw03_hyperlink_url.doc
mw03_table_with_hyper_links.doc</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/filters/kword/msword-odf/paragraph.h <span style="color: \
grey">(1158193)</span></li>
<li>trunk/koffice/filters/kword/msword-odf/paragraph.cpp <span style="color: \
grey">(1158193)</span></li>
<li>trunk/koffice/filters/kword/msword-odf/texthandler.h <span style="color: \
grey">(1158193)</span></li>
<li>trunk/koffice/filters/kword/msword-odf/texthandler.cpp <span style="color: \
grey">(1158193)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4755/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic