[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Shape in background
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2010-08-01 5:20:00
Message-ID: 20100801052000.30438.44245 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4797/#review6759
-----------------------------------------------------------
Can the same effect you are archiving with the runThrouh variable archived by \
changing the z-index of the shape?
As far as I have seen this property has only effect on how the main text is painted. \
So by manipulating the z-index of the shapes for all shapes that should be painted \
below the main text shape can be archived by setting the z-index lower then the one \
of the main text shape of kword.
When doing some testing I generated the the following file:
http://www.zagge.de/files/run_through.odt
It also has a background set on the main text frame. However that can't be done with \
your proposed solution.
I would like to add additional code to flake if it could be avoided.
- Thorsten
On 2010-07-30 14:42:37, Matus Hanzes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4797/
> -----------------------------------------------------------
>
> (Updated 2010-07-30 14:42:37)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This patch allows placing shapes behind text.
>
> https://bugs.kde.org/show_bug.cgi?id=239689
>
>
> Diffs
> -----
>
> trunk/koffice/kword/part/KWCanvas.h 1157153
> trunk/koffice/kword/part/KWCanvas.cpp 1157153
> trunk/koffice/kword/part/frames/KWCopyShape.cpp 1157153
> trunk/koffice/kword/part/frames/KWFrame.cpp 1157153
> trunk/koffice/libs/flake/KoShape.h 1157153
> trunk/koffice/libs/flake/KoShape.cpp 1157153
> trunk/koffice/libs/flake/KoShapeManager.h 1157153
> trunk/koffice/libs/flake/KoShapeManager.cpp 1157153
> trunk/koffice/libs/flake/KoShape_p.h 1157153
>
> Diff: http://reviewboard.kde.org/r/4797/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matus
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4797/">http://reviewboard.kde.org/r/4797/</a>
</td>
</tr>
</table>
<br />
<pre>Can the same effect you are archiving with the runThrouh variable archived by \
changing the z-index of the shape?
As far as I have seen this property has only effect on how the main text is painted. \
So by manipulating the z-index of the shapes for all shapes that should be painted \
below the main text shape can be archived by setting the z-index lower then the one \
of the main text shape of kword.
When doing some testing I generated the the following file:
http://www.zagge.de/files/run_through.odt
It also has a background set on the main text frame. However that can't be done \
with your proposed solution.
I would like to add additional code to flake if it could be avoided.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On July 30th, 2010, 2:42 p.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated 2010-07-30 14:42:37</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch allows placing shapes behind text.
https://bugs.kde.org/show_bug.cgi?id=239689
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/kword/part/KWCanvas.h <span style="color: \
grey">(1157153)</span></li>
<li>trunk/koffice/kword/part/KWCanvas.cpp <span style="color: \
grey">(1157153)</span></li>
<li>trunk/koffice/kword/part/frames/KWCopyShape.cpp <span style="color: \
grey">(1157153)</span></li>
<li>trunk/koffice/kword/part/frames/KWFrame.cpp <span style="color: \
grey">(1157153)</span></li>
<li>trunk/koffice/libs/flake/KoShape.h <span style="color: \
grey">(1157153)</span></li>
<li>trunk/koffice/libs/flake/KoShape.cpp <span style="color: \
grey">(1157153)</span></li>
<li>trunk/koffice/libs/flake/KoShapeManager.h <span style="color: \
grey">(1157153)</span></li>
<li>trunk/koffice/libs/flake/KoShapeManager.cpp <span style="color: \
grey">(1157153)</span></li>
<li>trunk/koffice/libs/flake/KoShape_p.h <span style="color: \
grey">(1157153)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4797/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic