'Review Request: msword-odf filter: Added basic logic into the .doc'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: msword-odf filter: Added basic logic into the .doc
From:       "Matus Uzak" <matus.uzak () ixonos ! com>
Date:       2010-07-30 18:11:07
Message-ID: 20100730181107.15189.22855 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4799/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

When you change the page background color in MS Word and don't choose a font color or style with a font \
color defined, then it is set to Auto. I added basic logic into the .doc filter to handle a font color \
set to Auto.  The background color information is provided by the GraphicsHandler.

However I still think that we should not provide any fo:color information in this case.  As this would be \
a valid ODT file, kword should handle this. Tests showed that ooo is also missing the logic.   

TODO: The "rule base" has to be extended based on test documents.    

This addresses bug 239702.
    https://bugs.kde.org/show_bug.cgi?id=239702

Diffs
-----

  trunk/koffice/filters/kword/msword-odf/document.h 1156605 
  trunk/koffice/filters/kword/msword-odf/document.cpp 1156605 
  trunk/koffice/filters/kword/msword-odf/graphicshandler.cpp 1156605 
  trunk/koffice/filters/kword/msword-odf/paragraph.h 1156605 
  trunk/koffice/filters/kword/msword-odf/paragraph.cpp 1156605 
  trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1156605 

Diff: http://reviewboard.kde.org/r/4799/diff

Testing
-------

Tested on the document attached to the bug report.  

Thanks,

Matus

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4799/">http://reviewboard.kde.org/r/4799/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; \
background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Matus Uzak.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0;">When you change the page background color in MS Word and don&#39;t \
choose a font color or style with a font color defined, then it is set to Auto. I added basic logic into \
the .doc filter to handle a font color set to Auto.  The background color information is provided by the \
GraphicsHandler.

However I still think that we should not provide any fo:color information in this case.  As this would be \
a valid ODT file, kword should handle this. Tests showed that ooo is also missing the logic.   

TODO: The &quot;rule base&quot; has to be extended based on test documents.    </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Tested on the document attached to the bug report.  </pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=239702">239702</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/filters/kword/msword-odf/document.h <span style="color: grey">(1156605)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/document.cpp <span style="color: grey">(1156605)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/graphicshandler.cpp <span style="color: \
grey">(1156605)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/paragraph.h <span style="color: grey">(1156605)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/paragraph.cpp <span style="color: grey">(1156605)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/texthandler.cpp <span style="color: \
grey">(1156605)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4799/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 