[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Small KWord fix for continuous pages adding
From: "Miroslav Nohaj" <miroslav.nohaj () ixonos ! com>
Date: 2010-07-28 12:27:56
Message-ID: 20100728122756.9375.32675 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-28 11:21:31, Thomas Zander wrote:
> > If you write a bugreport about this I might get to it and fix it myself. Its my component to \
> > maintain, afterall. I'd like this code to be free from maybe-this-works changes so I don't think this \
> > should be committed.
>
> Miroslav Nohaj wrote:
> But this 'one method call' fix _does_ work and was tested with two different documents: one to see if \
> your previous workaround (from svn revision 937897) still solves the old issue and one to see if my \
> workaround for your workaround solves the new issue.
> The bug report is here: https://bugs.kde.org/show_bug.cgi?id=239685
>
> Thomas Zander wrote:
> A "maybe-this-works" change can indeed work just fine for your test document, I didn't mean to say \
> otherwise. It doesn't make the patch correct or consistent with the rest of the code.
>
> The bugreport is good, its filed and needs to be investigated. Any findings you have would be good to \
> be added in details in the report as comments so someone else can continue without duplicating work.
> As mentioned; this is a "maybe-this-works" change, so please close the review as this should not be \
> committed.
OK, I'm closing it...
- Miroslav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4174/#review6723
-----------------------------------------------------------
On 2010-07-22 12:01:14, Miroslav Nohaj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4174/
> -----------------------------------------------------------
>
> (Updated 2010-07-22 12:01:14)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> When the .odt document contains only one paragraph which contains something (i.e. image) that is bigger \
> than one page, the layout tries to add one page to make it fit, but as that larger thing won't be put \
> on the first page, the situation repeats and it tries to add another page, and so on...
> The patch checks if the next shapes (together) have enough space to hold the current large thing and if \
> they do, it will not try to add more pages. I know that this might not the best solution so I'm \
> awaiting some recommendations from Thomas on what would be a better way to do it and as this patch will \
> be probably remade, it doesn't contain comments in the code.
>
> Diffs
> -----
>
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1134229
>
> Diff: http://reviewboard.kde.org/r/4174/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Miroslav
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4174/">http://reviewboard.kde.org/r/4174/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 28th, 2010, 11:21 a.m., <b>Thomas Zander</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>If you write a bugreport about this I might get to it and fix it myself. Its my component to \
maintain, afterall. I'd like this code to be free from maybe-this-works changes so I don't think \
this should be committed.</pre> </blockquote>
<p>On July 28th, 2010, 11:56 a.m., <b>Miroslav Nohaj</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>But this 'one method call' fix _does_ work and was tested with two different documents: \
one to see if your previous workaround (from svn revision 937897) still solves the old issue and one to \
see if my workaround for your workaround solves the new issue.
The bug report is here: https://bugs.kde.org/show_bug.cgi?id=239685</pre>
</blockquote>
<p>On July 28th, 2010, 12:24 p.m., <b>Thomas Zander</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>A "maybe-this-works" change can indeed work just fine for your test document, I \
didn't mean to say otherwise. It doesn't make the patch correct or consistent with the rest of \
the code.
The bugreport is good, its filed and needs to be investigated. Any findings you have would be good to be \
added in details in the report as comments so someone else can continue without duplicating work.
As mentioned; this is a "maybe-this-works" change, so please close the review as this should \
not be committed.</pre> </blockquote>
</blockquote>
<pre>OK, I'm closing it... </pre>
<br />
<p>- Miroslav</p>
<br />
<p>On July 22nd, 2010, 12:01 p.m., Miroslav Nohaj wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; \
background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Miroslav Nohaj.</div>
<p style="color: grey;"><i>Updated 2010-07-22 12:01:14</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">When the .odt document contains only one paragraph which contains \
something (i.e. image) that is bigger than one page, the layout tries to add one page to make it fit, but \
as that larger thing won't be put on the first page, the situation repeats and it tries to add \
another page, and so on...
The patch checks if the next shapes (together) have enough space to hold the current large thing and if \
they do, it will not try to add more pages. I know that this might not the best solution so I'm \
awaiting some recommendations from Thomas on what would be a better way to do it and as this patch will \
be probably remade, it doesn't contain comments in the code. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1134229)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4174/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic