I've uploaded a new set of patches to http://www.valdyas.org/~boud/graphicsview.tgz Changes: * following Marijn's review, made setCursor a KoCanvasBase method * following Marijn's review, renamed KoCanvasController::setDocumentSize(QSize, bool) to updateDocumentSize * removed a lot of code duplication in KWCanvas/KWCanvasItem by creating a KWCanbasBase I haven't changed the methods in KoDocument for creating a QGraphicsItem-based canvas yet, because I expect that he specifications for that will change anyway in the near future, and this works for now. Boudewijn _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel