[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Implementation of around wrap (on both sides)
From: "Casper Boemann" <cbr () boemann ! dk>
Date: 2010-07-24 8:01:16
Message-ID: 20100724080116.4825.15473 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-24 07:54:36, Casper Boemann wrote:
> > Interesting approach. I can't test it right now, but please test that it works if \
> > more than one shape is "dividing" the text
> > But it not bad at all if it works.
I'm pretty sure that this situation will not be handled:
text [BOTH SIDES SHAPE] text [BOTH SIDES SHAPE] text
- Casper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4744/#review6696
-----------------------------------------------------------
On 2010-07-23 14:07:29, Pavol Korinek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4744/
> -----------------------------------------------------------
>
> (Updated 2010-07-23 14:07:29)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This is patch - implementation of around wrap on both sides of any frame. \
> (https://bugs.kde.org/show_bug.cgi?id=239512)
>
> Diffs
> -----
>
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.h 1152963
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1152963
> /trunk/koffice/kword/part/frames/Outline.h 1152963
> /trunk/koffice/kword/part/frames/Outline.cpp 1152963
> /trunk/koffice/kword/part/tests/TestDocumentLayout.cpp 1152963
> /trunk/koffice/libs/kotext/KoTextDocumentLayout.h 1152963
> /trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp 1152963
> /trunk/koffice/plugins/textshape/Layout.h 1152963
> /trunk/koffice/plugins/textshape/Layout.cpp 1152963
>
> Diff: http://reviewboard.kde.org/r/4744/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pavol
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4744/">http://reviewboard.kde.org/r/4744/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 24th, 2010, 7:54 a.m., <b>Casper \
Boemann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre>Interesting approach. I can't test it right \
now, but please test that it works if more than one shape is "dividing" the \
text
But it not bad at all if it works.</pre>
</blockquote>
</blockquote>
<pre>I'm pretty sure that this situation will not be handled:
text [BOTH SIDES SHAPE] text [BOTH SIDES SHAPE] text
</pre>
<br />
<p>- Casper</p>
<br />
<p>On July 23rd, 2010, 2:07 p.m., Pavol Korinek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>
<p style="color: grey;"><i>Updated 2010-07-23 14:07:29</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This is patch - implementation of around wrap \
on both sides of any frame. (https://bugs.kde.org/show_bug.cgi?id=239512)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/Outline.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/Outline.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/tests/TestDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextDocumentLayout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1152963)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4744/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic