From koffice-devel Fri Jul 23 17:26:45 2010 From: "Matus Uzak" Date: Fri, 23 Jul 2010 17:26:45 +0000 To: koffice-devel Subject: Review Request: msword-odf filter: support for bookmarks inside of the Message-Id: <20100723172645.20757.9219 () localhost> X-MARC-Message: https://marc.info/?l=koffice-devel&m=127990603220109 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0701149839==" --===============0701149839== Content-Type: multipart/alternative; boundary="===============0649797918118306588==" --===============0649797918118306588== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4755/ ----------------------------------------------------------- Review request for KOffice. Summary ------- A field as described by [1] consist of field instructions and the field res= ult. While processing a .doc file a bookmark may refer to text of the fiel= d result. Patch description: * processing of the hyperlink field has been rewritten * added support for bookmarks in the field result of hyperlinks * added support for hyperlinks having a field result referring to a floatin= g or inline picture * removals in processing of the pageref field were consulted with Jean-Nico= las Artaud TODO: * the field result has to be placed into the element with the c= orrect style applied * there seems to be no support for the element * processing of all other fields has to be checked for bookmarks support = [1] [MS-DOC] Word Binary File Format (.doc) Structure Specification = Diffs ----- trunk/koffice/filters/kword/msword-odf/texthandler.h 1152617 = trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1152617 = Diff: http://reviewboard.kde.org/r/4755/diff Testing ------- mw00_hyperlink_picture.doc mw00_hyperlink_url.doc mw00_table_with_hyperlinks.doc mw03_hyperlink_picture.doc mw03_hyperlink_url.doc mw03_table_with_hyper_links.doc Thanks, Matus --===============0649797918118306588== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4755/

Review request for KOffice.
By Matus Uzak.

Descripti= on 

A field as described by [1] consis=
t of field instructions and the field result.  While processing a .doc file=
 a bookmark may refer to text of the field result.

Patch description:
* processing of the hyperlink field has been rewritten
* added support for bookmarks in the field result of hyperlinks
* added support for hyperlinks having a field result referring to a floatin=
g or inline picture
* removals in processing of the pageref field were consulted with Jean-Nico=
las Artaud

TODO:
* the field result has to be placed into the <text:span> element with=
 the correct style applied
* there seems to be no support for the <draw:a> element
* processing of all other fields has to be checked for bookmarks support
 =

[1] [MS-DOC] Word Binary File Format (.doc) Structure Specification

Testing <= /h1> 
mw00_hyperlink_picture.doc
mw00_hyperlink_url.doc
mw00_table_with_hyperlinks.doc
mw03_hyperlink_picture.doc
mw03_hyperlink_url.doc
mw03_table_with_hyper_links.doc

Diffs=

  • trunk/koffice/filters/kword/msword-odf/texthandler.h (1152617)
  • trunk/koffice/filters/kword/msword-odf/texthandler.cpp (1152617)

View Diff
--===============0649797918118306588==-- --===============0701149839== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0701149839==--