[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Implementation of around wrap (on both sides)
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2010-07-23 13:43:39
Message-ID: 20100723134339.14365.38867 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4744/#review6686
-----------------------------------------------------------
/trunk/koffice/kword/part/frames/Outline.cpp
<http://reviewboard.kde.org/r/4744/#comment6473>
True. Missed that.
- Inge
On 2010-07-23 13:29:02, Pavol Korinek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4744/
> -----------------------------------------------------------
>
> (Updated 2010-07-23 13:29:02)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This is patch - implementation of around wrap on both sides of any frame. \
> (https://bugs.kde.org/show_bug.cgi?id=239512)
>
> Diffs
> -----
>
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.h 1152963
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1152963
> /trunk/koffice/kword/part/frames/Outline.h 1152963
> /trunk/koffice/kword/part/frames/Outline.cpp 1152963
> /trunk/koffice/kword/part/tests/TestDocumentLayout.cpp 1152963
> /trunk/koffice/libs/kotext/KoTextDocumentLayout.h 1152963
> /trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp 1152963
> /trunk/koffice/plugins/textshape/Layout.h 1152963
> /trunk/koffice/plugins/textshape/Layout.cpp 1152963
>
> Diff: http://reviewboard.kde.org/r/4744/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pavol
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4744/">http://reviewboard.kde.org/r/4744/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31803#file31803line68" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/koffice/kword/part/frames/Outline.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">61</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"> <span class="k">if</span> <span \
class="p">(</span><span class="n">frame</span><span class="o">-></span><span \
class="n">textRunAround</span><span class="p">()</span> <span class="o">==</span> \
<span class="n">KWord</span><span class="o">::</span><span \
class="n">NoRunAround</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">68</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="k">if</span> <span class="p">(</span><span class="n">frame</span><span \
class="o">-></span><span class="n">textRunAround</span><span class="p">()</span> \
<span class="o">==</span> <span class="n">KWord</span><span class="o">::</span><span \
class="n">NoRunAround</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em">True. Missed that. </pre>
</div>
<br />
<p>- Inge</p>
<br />
<p>On July 23rd, 2010, 1:29 p.m., Pavol Korinek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>
<p style="color: grey;"><i>Updated 2010-07-23 13:29:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This is patch - implementation of around wrap \
on both sides of any frame. (https://bugs.kde.org/show_bug.cgi?id=239512)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/Outline.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/Outline.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/tests/TestDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextDocumentLayout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1152963)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4744/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic