[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Implementation of around wrap (on both sides)
From: "Pavol Korinek" <pavol.korinek () ixonos ! com>
Date: 2010-07-23 13:16:28
Message-ID: 20100723131628.14608.23610 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/KWTextDocumentLayout.h, line 26
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31800#file31800line26>
> >
> > Since you are only using a pointer below, a simple "class Outline;" would be \
> > enough. You can include the actual .h file in the .cpp.
done
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp, line 222
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31801#file31801line222>
> >
> > I know that not all members are documented, but how about doing a little better \
> > and add a short explanation?
done
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp, line 539
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31801#file31801line539>
> >
> > As we agreed on irc, maybe updateBaseline would be a better name.
done
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp, line 543
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31801#file31801line543>
> >
> > I don't think we should leave uncommented kDebug()'s laying around in code that \
> > we commit. It's fine during development, but please comment it before \
> > committing.
removed
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp, line 553
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31801#file31801line553>
> >
> > Yay, whitespace! :-)
haven't found
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp, line 639
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31801#file31801line639>
> >
> > I don't understand this comment. Maybe it's just because I don't understand the \
> > layout process.
changed
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/Outline.h, line 42
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31802#file31802line42>
> >
> > This name is a little too generic.
changed
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/Outline.cpp, line 68
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31803#file31803line68>
> >
> > Wouldn't a switch() make sense here? That way we would also get warnings on \
> > unhandled cases.
leaved as was, because there are two different geters checked.
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/Outline.cpp, line 157
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31803#file31803line157>
> >
> > the name m_actual_both_side should be explained and probably switched to \
> > something else. To what exactly depends on what it does.
done
> On 2010-07-23 12:07:33, Inge Wallin wrote:
> > /trunk/koffice/kword/part/frames/Outline.cpp, line 209
> > <http://reviewboard.kde.org/r/4744/diff/2/?file=31803#file31803line209>
> >
> > Here: and a couple of other places: The opening brace in a function goes to the \
> > left edge.
done
- Pavol
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4744/#review6683
-----------------------------------------------------------
On 2010-07-23 13:14:19, Pavol Korinek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4744/
> -----------------------------------------------------------
>
> (Updated 2010-07-23 13:14:19)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This is patch - implementation of around wrap on both sides of any frame.
>
>
> Diffs
> -----
>
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.h 1152963
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1152963
> /trunk/koffice/kword/part/frames/Outline.h 1152963
> /trunk/koffice/kword/part/frames/Outline.cpp 1152963
> /trunk/koffice/kword/part/tests/TestDocumentLayout.cpp 1152963
> /trunk/koffice/libs/kotext/KoTextDocumentLayout.h 1152963
> /trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp 1152963
> /trunk/koffice/plugins/textshape/Layout.h 1152963
> /trunk/koffice/plugins/textshape/Layout.cpp 1152963
>
> Diff: http://reviewboard.kde.org/r/4744/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pavol
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4744/">http://reviewboard.kde.org/r/4744/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31800#file31800line26" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/kword/part/frames/KWTextDocumentLayout.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">26</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: \
break-word;"><span class="cp">#include "Outline.h"</span></pre></td> </tr>
</tbody>
</table>
<pre>Since you are only using a pointer below, a simple "class Outline;" \
would be enough. You can include the actual .h file in the .cpp.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em">done</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31801#file31801line222" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">void \
KWTextDocumentLayout::layout()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">222</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="kt">bool</span> <span class="n">updateBottom</span> <span \
class="o">=</span> <span class="kc">true</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre>I know that not all members are documented, but how about doing a little \
better and add a short explanation?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em">done</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31801#file31801line539" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">532</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"> <span class="n">line</span><span \
class="p">.</span><span class="n">tryFit</span><span class="p">();</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">539</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: \
pre-wrap; word-wrap: break-word;"> <span class="n">line</span><span \
class="p">.</span><span class="n">tryFit</span><span class="p">(</span><span \
class="n"><span class="hl">updateBottom</span></span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre>As we agreed on irc, maybe updateBaseline would be a better name.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em">done</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31801#file31801line543" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">543</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="n">kDebug</span><span class="p">()</span> <span \
class="o"><<</span> <span class="s">"TESTX 1 fitted line "</span> \
<span class="o"><<</span> <span class="n">b</span><span class="p">.</span><span \
class="n">text</span><span class="p">().</span><span class="n">mid</span><span \
class="p">(</span><span class="n">line</span><span class="p">.</span><span \
class="n">line</span><span class="p">.</span><span class="n">textStart</span><span \
class="p">(),</span> <span class="n">line</span><span class="p">.</span><span \
class="n">line</span><span class="p">.</span><span class="n">textLength</span><span \
class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre>I don't think we should leave uncommented kDebug()'s laying around in \
code that we commit. It's fine during development, but please comment it before \
committing.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em">removed</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31801#file31801line553" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">553</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: \
break-word;"></pre></td> </tr>
</tbody>
</table>
<pre>Yay, whitespace! :-)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em">haven't found</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31801#file31801line639" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">624</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"> <span class="n">line</span><span \
class="p">.</span><span class="n">tryFit</span><span class="p">();</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">639</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: \
pre-wrap; word-wrap: break-word;"> <span class="c1">//switch to previous \
configuration of both side outlines before use tryFit for same line</span></pre></td> \
</tr>
</tbody>
</table>
<pre>I don't understand this comment. Maybe it's just because I don't \
understand the layout process.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em">changed</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31802#file31802line42" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/koffice/kword/part/frames/Outline.h</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">class Outline</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">42</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="n">QRectF</span> <span class="n">limit</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QRectF</span> <span \
class="o">&</span><span class="n">content</span><span class="p">,</span> <span \
class="n">bool</span> <span class="o">&</span><span \
class="n">updateBottom</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre>This name is a little too generic.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em">changed</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31803#file31803line68" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/koffice/kword/part/frames/Outline.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">61</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"> <span class="k">if</span> <span \
class="p">(</span><span class="n">frame</span><span class="o">-></span><span \
class="n">textRunAround</span><span class="p">()</span> <span class="o">==</span> \
<span class="n">KWord</span><span class="o">::</span><span \
class="n">NoRunAround</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">68</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="k">if</span> <span class="p">(</span><span class="n">frame</span><span \
class="o">-></span><span class="n">textRunAround</span><span class="p">()</span> \
<span class="o">==</span> <span class="n">KWord</span><span class="o">::</span><span \
class="n">NoRunAround</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre>Wouldn't a switch() make sense here? That way we would also get warnings \
on unhandled cases.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em">leaved as was, because there are two different geters \
checked.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31803#file31803line157" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/koffice/kword/part/frames/Outline.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">QRectF Outline::limit(const QRectF \
&content)</pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">QRectF \
Outline::limit(const QRectF &content, bool &updateBottom)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">157</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="n">m_actual_both_side</span> <span class="o">=</span> <span \
class="n">Left</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre>the name m_actual_both_side should be explained and probably switched to \
something else. To what exactly depends on what it does.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em">done</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 12:07 p.m., <b>Inge Wallin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4744/diff/2/?file=31803#file31803line209" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/koffice/kword/part/frames/Outline.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">qreal Outline::xAtY(const QLineF \
&line, qreal y)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">209</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: \
break-word;"><span class="kt">void</span> <span class="n">Outline</span><span \
class="o">::</span><span class="n">switchSide</span><span class="p">()</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre>Here: and a couple of other places: The opening brace in a function goes to \
the left edge.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em">done</pre>
<br />
<p>- Pavol</p>
<br />
<p>On July 23rd, 2010, 1:14 p.m., Pavol Korinek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>
<p style="color: grey;"><i>Updated 2010-07-23 13:14:19</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This is patch - implementation of around wrap \
on both sides of any frame.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/Outline.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/frames/Outline.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/kword/part/tests/TestDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextDocumentLayout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.h <span style="color: \
grey">(1152963)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1152963)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4744/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic