[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/kotext/styles
From:       Thomas Zander <zander () kde ! org>
Date:       2010-07-14 21:25:41
Message-ID: 201007142325.43326.zander () kde ! org
[Download RAW message or body]

On Wednesday 14. July 2010 22.01.53 Pierre Stirnweiss wrote:
> Well, here too I don't get what is the relation you see. The only common
> point I see is that both properties have the same value. But that does not
> qualify as them becoming related. I might change the default font point
> size to 10. It would be arguable in term of 10 being too small, but
> definitely not that it makes the font size related to the indent.


This is indeed not about the comments at all. Reviewboard makes threading hard 
to follow but what was written about the comments has little to do with the 
objection.
re-added the objection.  Its about this code;


1 KoListLevelProperties KoListStyle::levelProperties(int level) const
2 {
3     if (d->levels.contains(level))
4         return d->levels.value(level);
5
6     level = qMax(1, level);
7     if (d->levels.count()) {
8         KoListLevelProperties llp = d->levels.begin().value();
9         llp.setLevel(level);
a         return llp;
b     } 
c     KoListLevelProperties llp;
d     llp.setLevel(level);
e     if (d->styleId)
f         llp.setStyleId(d->styleId);
g     return llp;
h } 


Line 7 is there to return detect we don't have the level requested, but we have 
one already and as such we return a KoListLevelProperties based on another one 
already in the list style.

What the review requests adds is that the new one gets an indent set that is 
based on the list level.  This adds a relation between the indent and the level 
and only by explicitly overriding the indent later can the list style avoid 
having the two be related.
In KWord they were never related and indent is a separate setter in the UI.

My suggested solution was to add this relation in the ODF loading code instead 
as only OOo has this implied relation for list-levels not found in the odf-
input file.
-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]