[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/kotext/styles
From:       Thomas Zander <zander () kde ! org>
Date:       2010-07-14 16:50:12
Message-ID: 201007141850.13315.zander () kde ! org
[Download RAW message or body]

The policy written here;
http://wiki.koffice.org/index.php?title=Review_board_rules

is meant to avoid so called 'ping-pong commits'.  You committed a patch that 
was posted to reviewboard which had a clear objection. As indicated this is not 
what should happen. For that reason your commit was reverted.

The call to the wisemen sounds premature, their involvement should be limited 
to the situation where all other options have been exhausted.

I'd like to call on any koffice community member (to make sure its not just 
sebastian and me) to revert the commit again in line with the reviewboard 
rules. Marijn or Cyrille?
Next I hope we can have a new attempt at a solution made that is constructive 
and based on merit.


On Tuesday 13. July 2010 16.33.03 Sebastian Sauer wrote:
> SVN commit 1149472 by sebsauer:
> 
> revert r1149344 cause the asumption TZander provided [1] are wrong [2].
> 
> I am hereby calling the wise men for this case [3].
> CC_MAIL: koffice-devel@kde.org
> 
> [1] last comment on reviewboard.
> [2] he did not left me even one day to reply to show him why.
> [3] which should provide enough time to reply to his comment and, probably
> more important, it should result in something that fixes the original
> problem rather then just igoring it like the revert does plus it should
> finally provide a technical answer what's wrong with the patch (yes, I am
> still waiting for that one).
> 
> 
> 
>  M  +5 -0      KoListStyle.cpp
> 
> 
> --- trunk/koffice/libs/kotext/styles/KoListStyle.cpp #1149471:1149472
> @@ -123,12 +123,17 @@
>      if (d->levels.count()) {
>          KoListLevelProperties llp = d->levels.begin().value();
>          llp.setLevel(level);
> +        // TODO make the 10 configurable.
> +        llp.setIndent(level * 10.0);
> +        d->levels.insert(level, llp);
>          return llp;
>      }
> +
>      KoListLevelProperties llp;
>      llp.setLevel(level);
>      if (d->styleId)
>          llp.setStyleId(d->styleId);
> +    d->levels.insert(level, llp);
>      return llp;
>  }
> 
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]