[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Exact row height in KWord tables added
From: "Miroslav Nohaj" <miroslav.nohaj () ixonos ! com>
Date: 2010-07-02 13:16:57
Message-ID: 20100702131657.473.67052 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3319/
-----------------------------------------------------------
(Updated 2010-07-02 13:16:57.551040)
Review request for KOffice.
Changes
-------
Changes according to the last review made. Sorry for the things I missed in=
the one before - it happens to me when I get to some older review...
Summary
-------
This adds the exact row height to the tables of KWord (exact row height is =
an attribute from MS Word document as a complement to the minimum row heigh=
t). The text which does not fit in a cell in a row of small height is not d=
isplayed this way (does not go outside the cell). The other option would be=
to clip the text, but as that didn't work for the QTextLayout::draw(...) t=
his approach of not showing was chosen. Clipping would be nicer, not showin=
g is faster.
Diff r5 added week ago and I got no response. Please take a short while and=
go through the new version...
Diffs (updated)
-----
/trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1144208 =
/trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1144208 =
/trunk/koffice/plugins/textshape/Layout.cpp 1144208 =
/trunk/koffice/plugins/textshape/TableLayout.cpp 1144208 =
Diff: http://reviewboard.kde.org/r/3319/diff
Testing
-------
Thanks,
Miroslav
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/3319/">http://reviewboard.kde.org/r/3319/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Miroslav Nohaj.</div>
<p style="color: grey;"><i>Updated 2010-07-02 13:16:57.551040</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Changes according to the last review made. \
Sorry for the things I missed in the one before - it happens to me when I get to some \
older review...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This adds the exact row height to the tables \
of KWord (exact row height is an attribute from MS Word document as a complement to \
the minimum row height). The text which does not fit in a cell in a row of small \
height is not displayed this way (does not go outside the cell). The other option \
would be to clip the text, but as that didn't work for the QTextLayout::draw(...) \
this approach of not showing was chosen. Clipping would be nicer, not showing is \
faster.
Diff r5 added week ago and I got no response. Please take a short while and go \
through the new version...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/kotext/styles/KoTableRowStyle.h <span style="color: \
grey">(1144208)</span></li>
<li>/trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp <span style="color: \
grey">(1144208)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1144208)</span></li>
<li>/trunk/koffice/plugins/textshape/TableLayout.cpp <span style="color: \
grey">(1144208)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/3319/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic