'Review Request: Gradient preset that use foreground/background,'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Gradient preset that use foreground/background,
From:       "Sven Langkamp" <sven.langkamp () gmail ! com>
Date:       2010-06-30 18:31:37
Message-ID: 20100630183137.29992.50267 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4501/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

The following patch add two gradients that are go from foreground to backgr=
ound and foreground to transparent. It adds update functionality for resour=
ce server. Adds two gradients that are not saved to disk.

Updating currently only works in Krita at the moment as I haven't found a g=
ood place to make use of it KOffice wide.

Diffs
-----

  /trunk/koffice/krita/plugins/paintops/libbrush/kis_brush_server.cpp 11433=
98 =

  /trunk/koffice/krita/ui/kis_canvas_resource_provider.cpp 1143398 =

  /trunk/koffice/libs/pigment/resources/KoStopGradient.h 1141841 =

  /trunk/koffice/libs/pigment/resources/KoStopGradient.cpp 1141841 =

  /trunk/koffice/libs/widgets/KoResourceModel.h 1141841 =

  /trunk/koffice/libs/widgets/KoResourceModel.cpp 1141841 =

  /trunk/koffice/libs/widgets/KoResourceServer.h 1141841 =

  /trunk/koffice/libs/widgets/KoResourceServerAdapter.h 1141841 =

  /trunk/koffice/libs/widgets/KoResourceServerAdapter.cpp 1141841 =

  /trunk/koffice/libs/widgets/KoResourceServerObserver.h 1141841 =

  /trunk/koffice/libs/widgets/KoResourceServerProvider.cpp 1141841 =

Diff: http://reviewboard.kde.org/r/4501/diff

Testing
-------

Thanks,

Sven

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4501/">http://reviewboard.kde.org/r/4501/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">The following patch add two gradients that are \
go from foreground to background and foreground to transparent. It adds update \
functionality for resource server. Adds two gradients that are not saved to disk.

Updating currently only works in Krita at the moment as I haven&#39;t found a good \
place to make use of it KOffice wide.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/krita/plugins/paintops/libbrush/kis_brush_server.cpp <span \
style="color: grey">(1143398)</span></li>

 <li>/trunk/koffice/krita/ui/kis_canvas_resource_provider.cpp <span style="color: \
grey">(1143398)</span></li>

 <li>/trunk/koffice/libs/pigment/resources/KoStopGradient.h <span style="color: \
grey">(1141841)</span></li>

 <li>/trunk/koffice/libs/pigment/resources/KoStopGradient.cpp <span style="color: \
grey">(1141841)</span></li>

 <li>/trunk/koffice/libs/widgets/KoResourceModel.h <span style="color: \
grey">(1141841)</span></li>

 <li>/trunk/koffice/libs/widgets/KoResourceModel.cpp <span style="color: \
grey">(1141841)</span></li>

 <li>/trunk/koffice/libs/widgets/KoResourceServer.h <span style="color: \
grey">(1141841)</span></li>

 <li>/trunk/koffice/libs/widgets/KoResourceServerAdapter.h <span style="color: \
grey">(1141841)</span></li>

 <li>/trunk/koffice/libs/widgets/KoResourceServerAdapter.cpp <span style="color: \
grey">(1141841)</span></li>

 <li>/trunk/koffice/libs/widgets/KoResourceServerObserver.h <span style="color: \
grey">(1141841)</span></li>

 <li>/trunk/koffice/libs/widgets/KoResourceServerProvider.cpp <span style="color: \
grey">(1141841)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4501/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 