'Review Request: patch prevents ASSERT CRASH in table layout'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: patch prevents ASSERT CRASH in table layout
From:       "Pavol Korinek" <pavol.korinek () ixonos ! com>
Date:       2010-06-30 11:15:49
Message-ID: 20100630111549.16819.86206 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4500/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

Adding outline restrictions for shapes (frames) has changed. Shapes with run-through \
attribute are not included now. Patch prevents Q_ASSERT(bottom >= top) crash in \
TableLayout::setCellContentHeight method.

Diffs
-----

  /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1144278 

Diff: http://reviewboard.kde.org/r/4500/diff

Testing
-------

Thanks,

Pavol

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4500/">http://reviewboard.kde.org/r/4500/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Adding outline restrictions for shapes \
(frames) has changed. Shapes with run-through attribute are not included now. Patch \
prevents Q_ASSERT(bottom &gt;= top) crash in TableLayout::setCellContentHeight \
method.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1144278)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4500/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 