[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Menu/toolbars not always built correctly
From: "David Faure" <faure () kde ! org>
Date: 2010-06-29 20:32:08
Message-ID: 20100629203208.25220.58032 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4492/#review6320
-----------------------------------------------------------
The bug where all the empty menus would remain (go, games etc.) could be th=
e one I just fixed in kdelibs r1144396, however it was only happening when =
the xmlfile wasn't found (and there would be a warning on stderr).
Other than that, I'm a bit surprised by the complexity. Do I understand cor=
rectly that one of the issues is that a locally modified koffice_shell.rc w=
ould include a full copy of ui_standards.rc, therefore new versions of ui_s=
tandards.rc would be ignored? (Well, it's not like we change that one very =
often these days).
To say it otherwise, I wonder why koffice would need all this extra code, w=
hen the theory is that it's just like an app whose rc file is koffice_shell=
.rc. There's no per-app file on top of that, all the e.g. KWord stuff still=
comes from a part, right?
Ah the one difference is that for the standard kxmlguiclient code to work, =
it would need to be set up with a setComponentData(KComponentData("koffice"=
)), basically, so that setXMLFile("koffice_shell.rc") finds koffice/koffice=
_shell.rc. This is worth a try, I think; or what do I miss?
- David
On 2010-06-29 11:47:42, Dag Andersen wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4492/
> -----------------------------------------------------------
> =
> (Updated 2010-06-29 11:47:42)
> =
> =
> Review request for KOffice and David Faure.
> =
> =
> Summary
> -------
> =
> There has been problems lately with getting the correct layout of menus a=
nd toolbars.
> Sometimes the help menu is gone, other times empty menu entries defined i=
n ui_standars.rc is included (game, go, move, etc) although no koffice app =
defines them.
> AFAICS this is because there is two files (ui_standars.rc and koffice_she=
ll.rc) in main window level that defines the ui.
> Sometimes ui_standards.rc is not loaded when it should, sometimes koffice=
_shell.rc is not loaded. The reason for this is that the kde standard does =
not quite support this regime.
> The attached patch reimplements createShellGUI(), to make sure that ui_st=
andards.rc is loaded when there is a new revision of ui_standard.rc or ther=
e is no local koffice_shell.rc. This ensures that the help menu is created.
> Also it handles revision control of ui_standards.rc separatly to avoid th=
at all the ui_standards.rc definitions accidentally ends up in the local ko=
ffice_shell.rc
> =
> =
> Diffs
> -----
> =
> trunk/koffice/libs/main/KoMainWindow.h 1140071 =
> trunk/koffice/libs/main/KoMainWindow.cpp 1140071 =
> =
> Diff: http://reviewboard.kde.org/r/4492/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dag
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4492/">http://reviewboard.kde.org/r/4492/</a>
</td>
</tr>
</table>
<br />
<pre>The bug where all the empty menus would remain (go, games etc.) could be the \
one I just fixed in kdelibs r1144396, however it was only happening when the xmlfile \
wasn't found (and there would be a warning on stderr).
Other than that, I'm a bit surprised by the complexity. Do I understand correctly \
that one of the issues is that a locally modified koffice_shell.rc would include a \
full copy of ui_standards.rc, therefore new versions of ui_standards.rc would be \
ignored? (Well, it's not like we change that one very often these days).
To say it otherwise, I wonder why koffice would need all this extra code, when the \
theory is that it's just like an app whose rc file is koffice_shell.rc. \
There's no per-app file on top of that, all the e.g. KWord stuff still comes from \
a part, right?
Ah the one difference is that for the standard kxmlguiclient code to work, it would \
need to be set up with a setComponentData(KComponentData("koffice")), \
basically, so that setXMLFile("koffice_shell.rc") finds \
koffice/koffice_shell.rc. This is worth a try, I think; or what do I miss?</pre> <br \
/>
<p>- David</p>
<br />
<p>On June 29th, 2010, 11:47 a.m., Dag Andersen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice and David Faure.</div>
<div>By Dag Andersen.</div>
<p style="color: grey;"><i>Updated 2010-06-29 11:47:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">There has been problems lately with getting \
the correct layout of menus and toolbars. Sometimes the help menu is gone, other \
times empty menu entries defined in ui_standars.rc is included (game, go, move, etc) \
although no koffice app defines them. AFAICS this is because there is two files \
(ui_standars.rc and koffice_shell.rc) in main window level that defines the ui. \
Sometimes ui_standards.rc is not loaded when it should, sometimes koffice_shell.rc is \
not loaded. The reason for this is that the kde standard does not quite support this \
regime. The attached patch reimplements createShellGUI(), to make sure that \
ui_standards.rc is loaded when there is a new revision of ui_standard.rc or there is \
no local koffice_shell.rc. This ensures that the help menu is created. Also it \
handles revision control of ui_standards.rc separatly to avoid that all the \
ui_standards.rc definitions accidentally ends up in the local koffice_shell.rc</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/main/KoMainWindow.h <span style="color: \
grey">(1140071)</span></li>
<li>trunk/koffice/libs/main/KoMainWindow.cpp <span style="color: \
grey">(1140071)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4492/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic