[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: KDChart::Legend bug: incorrect brushes used when datasets are
From: Sebastian Sauer <sebastian.sauer () kdab ! com>
Date: 2010-06-28 16:44:23
Message-ID: 201006281844.26511.sebastian.sauer () kdab ! com
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
[Attachment #4 (multipart/alternative)]
Dag Andersen wrote:
> In Legend::buildLegend() hidden datasets are not taken into account when
> brushes are fetched.
> I suspect it is the the same with pens and markers also but I haven't
> tested that.
Afaik yes, it's the same with brushes and pens. iirc the problem here was that
multiple dimensions where not handled correct. That was fixed later and it
seems the fix that also addresses this issue is rather big and touches lot of
lines. But probably Johannes can answer it more detailed if he likes cause it
seems he fixed it :)
> What I do is creating a clean legend and set a diagram that has a source
> model that returns a brush for all (6) datasets. When all datasets are
> shown, I get the correct brushes. My expectation is that when I hide e.g.
> dataset 0, 1 and 2, I should get the brushes for dataset 3, 4,and 5.
> Instead I get brushes for 1, 2 and 3.
>
> The pacth fixes this, but as I said I suspect pens and markers also, and
> there is so many defaults and fall-backs that I might have missed a trick
> or two.
I would suggest to apply that patch asap to koffice/kdchart/kdchart/* to get
right of the prob for now. Since it's fixed in 2.4.0 it will not make a
difference once we merge 2.4.0.
I am not sure re the crash-fix yet. Guess I need some more time to understand
what the prob is. But just like before I would suggest to commit first and
review later.
[Attachment #7 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'DejaVu Sans'; font-size:8pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><span style=" font-family:'DejaVu Sans Mono';">Dag Andersen \
wrote:</span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span \
style=" font-family:'DejaVu Sans Mono';">> In Legend::buildLegend() hidden \
datasets are not taken into account when</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><span style=" font-family:'DejaVu Sans \
Mono';">> brushes are fetched.</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><span style=" font-family:'DejaVu Sans \
Mono';">> I suspect it is the the same with pens and markers also but I \
haven't</span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span \
style=" font-family:'DejaVu Sans Mono';">> tested that.</span></p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" \
font-family:'DejaVu Sans Mono';">Afaik yes, it's the same with brushes and pens. iirc \
the problem here was that multiple dimensions where not handled correct. That was \
fixed later and it seems the fix that also addresses this issue is rather big and \
touches lot of lines. But probably Johannes can answer it more detailed if he likes \
cause it seems he fixed it :)</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><span style=" font-family:'DejaVu Sans Mono';"> \
</span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span \
style=" font-family:'DejaVu Sans Mono';">> What I do is creating a clean legend \
and set a diagram that has a source</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><span style=" font-family:'DejaVu Sans \
Mono';">> model that returns a brush for all (6) datasets. When all datasets \
are</span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span \
style=" font-family:'DejaVu Sans Mono';">> shown, I get the correct brushes. My \
expectation is that when I hide e.g.</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><span style=" font-family:'DejaVu Sans \
Mono';">> dataset 0, 1 and 2, I should get the brushes for dataset 3, 4,and \
5.</span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span \
style=" font-family:'DejaVu Sans Mono';">> Instead I get brushes for 1, 2 and \
3.</span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span \
style=" font-family:'DejaVu Sans Mono';">> </span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><span style=" font-family:'DejaVu Sans \
Mono';">> The pacth fixes this, but as I said I suspect pens and markers also, \
and</span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span \
style=" font-family:'DejaVu Sans Mono';">> there is so many defaults and \
fall-backs that I might have missed a trick</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><span style=" font-family:'DejaVu Sans \
Mono';">> or two.</span></p> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0; font-family:'DejaVu Sans Mono';"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" \
font-family:'DejaVu Sans Mono';">I would suggest to apply that patch asap to \
koffice/kdchart/kdchart/* to get right of the prob for now. Since it's fixed in 2.4.0 \
it will not make a difference once we merge 2.4.0. </span></p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0; \
font-family:'DejaVu Sans Mono';"></p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><span style=" font-family:'DejaVu Sans Mono';">I am not sure re \
the crash-fix yet. Guess I need some more time to understand what the prob is. But \
just like before I would suggest to commit first and review later.</span></p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0; \
font-family:'DejaVu Sans Mono';"></p></body></html>
["smime.p7s" (application/pkcs7-signature)]
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic