'Review Request: fix: Table loading'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: fix: Table loading
From:       "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date:       2010-06-28 7:00:30
Message-ID: 20100628070030.32403.68843 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4466/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

Problems fixed:

1. =

If I understand it right KoTextLoader::loadTable should place one block bef=
ore table, then call qt insertTable, which adds table and one block after i=
t.
Instead of placing one block before the table KoTextLoader::loadTable place=
s it at the end of the document.

2.
Block before the table inherits page break from previous block so we have t=
wo page breaks instead of one.

3.
When master page style is defined in table it should be moved to previous b=
lock, because this block is part of the table.

Diffs
-----

  trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1142744 =

Diff: http://reviewboard.kde.org/r/4466/diff

Testing
-------

Thanks,

Matus

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4466/">http://reviewboard.kde.org/r/4466/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; \
background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Matus Hanzes.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Problems fixed:

1. 
If I understand it right KoTextLoader::loadTable should place one block before table, then call qt \
insertTable, which adds table and one block after it. Instead of placing one block before the table \
KoTextLoader::loadTable places it at the end of the document.

2.
Block before the table inherits page break from previous block so we have two page breaks instead of one.

3.
When master page style is defined in table it should be moved to previous block, because this block is \
part of the table.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1142744)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4466/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 