'Re: Review Request: Kword: Add handlig of page center anchor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kword: Add handlig of page center anchor
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-06-26 7:59:58
Message-ID: 20100626075958.25618.7208 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4443/#review6293
-----------------------------------------------------------

Ship it!

trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp
<http://reviewboard.kde.org/r/4443/#comment5954>

    coding style ;)   Please add a space between if and open brace

- Thomas

On 2010-06-23 08:27:55, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4443/
> -----------------------------------------------------------
> 
> (Updated 2010-06-23 08:27:55)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Added support for anchor position "style:horizontal-pos" = "page" and "style:horizontal-rel" = "center".
> 
>  
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1141676 
>   trunk/koffice/libs/kotext/KoTextAnchor.h 1141676 
>   trunk/koffice/libs/kotext/KoTextAnchor.cpp 1141676 
> 
> Diff: http://reviewboard.kde.org/r/4443/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4443/">http://reviewboard.kde.org/r/4443/</a>
     </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a href="/r/4443/diff/1/?file=29626#file29626line145" style="color: black; \
font-weight: bold; text-decoration: underline;">trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp</a>  \
<span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">bool KWAnchorStrategy::checkState(KoTextDocumentLayout::LayoutState *state, int \
startOfBlock, int startOfBlockText, KWTextFrameSet *frameSet)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">145</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">        <span class="k">if</span><span \
class="p">(</span><span class="n">pageInfo</span><span class="p">)</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">coding style ;)   Please add a space between if and open brace</pre>
</div>
<br />

<p>- Thomas</p>

<br />
<p>On June 23rd, 2010, 8:27 a.m., Matus Hanzes wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; \
background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Matus Hanzes.</div>

<p style="color: grey;"><i>Updated 2010-06-23 08:27:55</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Added support for anchor position &quot;style:horizontal-pos&quot; \
= &quot;page&quot; and &quot;style:horizontal-rel&quot; = &quot;center&quot;.

 </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp <span style="color: grey">(1141676)</span></li>

 <li>trunk/koffice/libs/kotext/KoTextAnchor.h <span style="color: grey">(1141676)</span></li>

 <li>trunk/koffice/libs/kotext/KoTextAnchor.cpp <span style="color: grey">(1141676)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4443/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 