'Re: Review Request: msword-odf: Fix for the interference between'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: msword-odf: Fix for the interference between
From:       "Jean-Nicolas Artaud" <jeannicolasartaud () gmail ! com>
Date:       2010-06-24 9:18:46
Message-ID: 20100624091846.31881.34117 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4446/#review6255
-----------------------------------------------------------

Ship it!

You can also remove the second FIXME by removing the dead code as we said.

- Jean-Nicolas

On 2010-06-23 16:57:24, Matus Uzak wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4446/
> -----------------------------------------------------------
> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> The storage of bookmarks differs between [1] and [2].  There are also res=
trictions for the case that a bookmark is located somewhere in the middle o=
f a field, which I have followed to some extent.      =

> =

> TODO: =

> * A few FIXME comments have to be discussed with the original author. :) =

> * Interference between bookmarks and tables.   =

> =

> [1] Microsoft Word 97 Binary File Format
> [2] Microsoft Word 6.0 Binary File Format
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1141392 =

>   trunk/koffice/filters/kword/msword-odf/wv2/src/bookmark.h 1141691 =

>   trunk/koffice/filters/kword/msword-odf/wv2/src/bookmark.cpp 1141691 =

>   trunk/koffice/filters/kword/msword-odf/wv2/src/parser9x.h 1141691 =

>   trunk/koffice/filters/kword/msword-odf/wv2/src/parser9x.cpp 1141691 =

> =

> Diff: http://reviewboard.kde.org/r/4446/diff
> =

> =

> Testing
> -------
> =

> Docs attached to bug n. 134050 in PMO bugzilla.  =

> =

> =

> Thanks,
> =

> Matus
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4446/">http://reviewboard.kde.org/r/4446/</a>
     </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre>You can also remove the second FIXME by removing the dead code as we said.</pre>
 <br />

<p>- Jean-Nicolas</p>

<br />
<p>On June 23rd, 2010, 4:57 p.m., Matus Uzak wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; \
background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Matus Uzak.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0;">The storage of bookmarks differs between [1] and [2].  There are \
also restrictions for the case that a bookmark is located somewhere in the middle of a field, which I \
have followed to some extent.      

TODO: 
* A few FIXME comments have to be discussed with the original author. :) 
* Interference between bookmarks and tables.   

[1] Microsoft Word 97 Binary File Format
[2] Microsoft Word 6.0 Binary File Format</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Docs attached to bug n. 134050 in PMO bugzilla.  </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/filters/kword/msword-odf/texthandler.cpp <span style="color: \
grey">(1141392)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/wv2/src/bookmark.h <span style="color: \
grey">(1141691)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/wv2/src/bookmark.cpp <span style="color: \
grey">(1141691)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/wv2/src/parser9x.h <span style="color: \
grey">(1141691)</span></li>

 <li>trunk/koffice/filters/kword/msword-odf/wv2/src/parser9x.cpp <span style="color: \
grey">(1141691)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4446/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 