[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix missing stroke style
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2010-06-23 9:56:26
Message-ID: 20100623095626.2883.25210 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4431/#review6249
-----------------------------------------------------------
Ship it!
Looks good. Please commit with the optimization.
trunk/koffice/libs/flake/KoOdfWorkaround.cpp
<http://reviewboard.kde.org/r/4431/#comment5842>
This can be optimized by writing changing it to
const QString strokeColor(styleStack.property(KoXmlNS::draw, "stroke-color")); \
if (strokeColor.isEmpty()) { \
pen.setColor(Qt::black); \
} \
else { \
pen.setColor(strokeColor); \
}
This avoids the second lookup in case the stroke-color is given. \
- Thorsten
On 2010-06-23 09:43:11, Sven Langkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4431/
> -----------------------------------------------------------
>
> (Updated 2010-06-23 09:43:11)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> OpenOffice sometimes doesn't save the stroke style. The patch extends the ODF workaround to \
> assume a black one pixel stroke.
>
> This addresses bug 239676.
> https://bugs.kde.org/show_bug.cgi?id=239676
>
>
> Diffs
> -----
>
> trunk/koffice/libs/flake/KoOdfWorkaround.cpp 1140895
>
> Diff: http://reviewboard.kde.org/r/4431/diff
>
>
> Testing
> -------
>
> Autoform in 231727 now show up. Also a number of other bugs show borders now (231727, 231728, \
> 231725).
>
> Thanks,
>
> Sven
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4431/">http://reviewboard.kde.org/r/4431/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>Looks good. Please commit with the optimization.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a href="/r/4431/diff/2/?file=29629#file29629line166" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/flake/KoOdfWorkaround.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: \
pre-wrap; word-wrap: break-word;">bool KoOdfWorkaround::fixMissingStroke(QPen &pen, const \
KoXmlElement &element, KoShapeLoadingContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">165</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: \
break-word;"> <span class="k">if</span><span class="p">(</span><span \
class="o">!</span><span class="n">styleStack</span><span class="p">.</span><span \
class="n">property</span><span class="p">(</span><span class="n">KoXmlNS</span><span \
class="o">::</span><span class="n">draw</span><span class="p">,</span> <span \
class="s">"stroke-color"</span><span class="p">).</span><span \
class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em">This can be optimized by writing changing it to
const QString strokeColor(styleStack.property(KoXmlNS::draw, "stroke-color")); \
if (strokeColor.isEmpty()) { \
pen.setColor(Qt::black); \
} \
else { \
pen.setColor(strokeColor); \
}
This avoids the second lookup in case the stroke-color is given. \
</pre> </div>
<br />
<p>- Thorsten</p>
<br />
<p>On June 23rd, 2010, 9:43 a.m., Sven Langkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>
<p style="color: grey;"><i>Updated 2010-06-23 09:43:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">OpenOffice sometimes doesn't save the stroke style. \
The patch extends the ODF workaround to assume a black one pixel stroke.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Autoform in 231727 now show up. Also a number of other \
bugs show borders now (231727, 231728, 231725).</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=239676">239676</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/flake/KoOdfWorkaround.cpp <span style="color: \
grey">(1140895)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4431/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic