'Re: Review Request: Fix missing stroke style'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix missing stroke style
From:       "Sven Langkamp" <sven.langkamp () gmail ! com>
Date:       2010-06-23 9:43:11
Message-ID: 20100623094311.2615.28711 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4431/
-----------------------------------------------------------

(Updated 2010-06-23 09:43:11.239676)

Review request for KOffice.

Changes
-------

Checks for stroke-color now.

Summary
-------

OpenOffice sometimes doesn't save the stroke style. The patch extends the ODF \
workaround to assume a black one pixel stroke.

This addresses bug 239676.
    https://bugs.kde.org/show_bug.cgi?id=239676

Diffs (updated)
-----

  trunk/koffice/libs/flake/KoOdfWorkaround.cpp 1140895 

Diff: http://reviewboard.kde.org/r/4431/diff

Testing
-------

Autoform in 231727 now show up. Also a number of other bugs show borders now (231727, \
231728, 231725).

Thanks,

Sven

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4431/">http://reviewboard.kde.org/r/4431/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>

<p style="color: grey;"><i>Updated 2010-06-23 09:43:11.239676</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Checks for stroke-color now.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">OpenOffice sometimes doesn&#39;t save the \
stroke style. The patch extends the ODF workaround to assume a black one pixel \
stroke.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Autoform in 231727 now show up. Also a number \
of other bugs show borders now (231727, 231728, 231725).</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=239676">239676</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/flake/KoOdfWorkaround.cpp <span style="color: \
grey">(1140895)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4431/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 