'Re: Review Request: Remove all the useless things about msword'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Remove all the useless things about msword
From:       "Jean-Nicolas Artaud" <jeannicolasartaud () gmail ! com>
Date:       2010-06-22 9:09:02
Message-ID: 20100622090902.5649.43449 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4381/
-----------------------------------------------------------

(Updated 2010-06-22 09:09:01.912948)

Review request for KOffice.

Changes
-------

Remove also the parser9x::parseBookmark method that was useless at this mom=
ent.

Summary
-------

Remove all the useless things about msword bookmarks import:
 - Signals were not needed because the bookmarks import is done at the read=
, and not in a parallel workflow.
 - Bookmarks Start and End were empty.
 - the content of the slotBookmarkFound was leading to crashes, and doesn't=
 add any bookmarks

It fixes some crashes too (subdoc were bad and useless in this case)

Diffs (updated)
-----

  /trunk/koffice/libs/kotext/opendocument/KoTextWriter.cpp 1131071 =

Diff: http://reviewboard.kde.org/r/4381/diff

Testing
-------

msword_2003_bookmarks_text.doc
mw00_bookmark_text.doc
mw00_hyperlink_url.doc

Thanks,

Jean-Nicolas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4381/">http://reviewboard.kde.org/r/4381/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Jean-Nicolas Artaud.</div>

<p style="color: grey;"><i>Updated 2010-06-22 09:09:01.912948</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Remove also the parser9x::parseBookmark method \
that was useless at this moment.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Remove all the useless things about msword \
                bookmarks import:
 - Signals were not needed because the bookmarks import is done at the read, and not \
                in a parallel workflow.
 - Bookmarks Start and End were empty.
 - the content of the slotBookmarkFound was leading to crashes, and doesn&#39;t add \
any bookmarks

It fixes some crashes too (subdoc were bad and useless in this case)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">msword_2003_bookmarks_text.doc
mw00_bookmark_text.doc
mw00_hyperlink_url.doc</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/libs/kotext/opendocument/KoTextWriter.cpp <span style="color: \
grey">(1131071)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4381/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 