[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Added support for master page style in tables
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-06-21 15:27:17
Message-ID: 20100621152717.16181.23104 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-06-17 18:59:30, Thomas Zander wrote:
> > Please explain the bug you are trying to fix first. I can't see why you=
would need this...
> > Since this is tables and layout code, unit tests to show the bug are ve=
ry strongly suggested.
> > =
> > Also, I think your usage of 'section' is confusing, it doesn't seem to =
be similar to what sections mean in other usages.
> =
> Matus Hanzes wrote:
> This feature is in msword 2007 and open office called section that is=
why I am calling it section. But we can agree on some other naming.
> =
> =
> This patch adds kword support for msword 2007 "next page section brea=
k".
> =
> This feature is written in odf by adding style:master-page-name to pa=
ragraph or table.
> =
> There is already support for new master page style in paragraphs. (st=
yle:master-page-name is added to paragraph)
> I have added support for new master page style in tables. (style:mast=
er-page-name is added to table)
> =
> In this patch I check if style:master-page-name is added to table and=
if yes table is placed on next page.
> =
>
Thanks for the explanation, that allows anyone doing review to know what th=
ey are looking at. I'll try to do a review soonish.
Any chance you can add unit tests?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4369/#review6170
-----------------------------------------------------------
On 2010-06-17 15:15:40, Matus Hanzes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4369/
> -----------------------------------------------------------
> =
> (Updated 2010-06-17 15:15:40)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> If paragraph or table have master page style, it means that new section s=
hould start.
> =
> There is already support for new master page style in paragraphs.
> I have added support for new master page style in tables.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/plugins/textshape/Layout.h 1139065 =
> trunk/koffice/plugins/textshape/Layout.cpp 1139065 =
> =
> Diff: http://reviewboard.kde.org/r/4369/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Matus
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4369/">http://reviewboard.kde.org/r/4369/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 17th, 2010, 6:59 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre>Please explain the bug you are trying to fix \
first. I can't see why you would need this... Since this is tables and layout \
code, unit tests to show the bug are very strongly suggested.
Also, I think your usage of 'section' is confusing, it doesn't seem to be \
similar to what sections mean in other usages.</pre> </blockquote>
<p>On June 21st, 2010, 7:54 a.m., <b>Matus Hanzes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre>This feature is in msword 2007 and open office called section that is \
why I am calling it section. But we can agree on some other naming.
This patch adds kword support for msword 2007 "next page section break".
This feature is written in odf by adding style:master-page-name to paragraph or \
table.
There is already support for new master page style in paragraphs. \
(style:master-page-name is added to paragraph) I have added support for new master \
page style in tables. (style:master-page-name is added to table)
In this patch I check if style:master-page-name is added to table and if yes table is \
placed on next page.
</pre>
</blockquote>
</blockquote>
<pre>Thanks for the explanation, that allows anyone doing review to know what they \
are looking at. I'll try to do a review soonish. Any chance you can add unit \
tests?</pre> <br />
<p>- Thomas</p>
<br />
<p>On June 17th, 2010, 3:15 p.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated 2010-06-17 15:15:40</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">If paragraph or table have master page style, \
it means that new section should start.
There is already support for new master page style in paragraphs.
I have added support for new master page style in tables.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/plugins/textshape/Layout.h <span style="color: \
grey">(1139065)</span></li>
<li>trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1139065)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4369/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic