[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Speed up loading of paragraph styles
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-06-18 9:50:53
Message-ID: 20100618095053.860.44655 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4380/#review6180
-----------------------------------------------------------

Ship it!


I valgrinded with two documents: the opendocument 1.1 specification (kword can load \
it, but not layout) and a really simple document with lots of pages but nearly no \
styles. The simple document went from 0:52 to 0:50 for a total of 28 calls to \
KoParagraphStyle::loadOdf, the complex document from 22:15 to 21:49 for 4605 calls. \
The savings are not spectacular, but consistent, so I would like this patch to be \
committed.

I can mail 4 valgrind logs plus the simple but big test document. I cannot put that \
document on my webserver, since it's somebodies draft novel which I don't want to \
appear on rapidshape :-).

- Boudewijn


On 2010-06-18 03:54:55, Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4380/
> -----------------------------------------------------------
> 
> (Updated 2010-06-18 03:54:55)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Speed up loading of paragraph styles.
> 
> Using first
> 
> styleStack.hasProperty(KoXmlNS::fo, "text-align"))                                  \
>  
> to check if a property is there and after that 
> 
> const QString textAlign(styleStack.property(KoXmlNS::fo, "text-align"))             \
>  
> to get the value needs to iterate over the whole stack twice when the attribute is \
> found.  just using the second method is enough as it will return an empty QString \
> when the attribute was not found. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1139119 
> 
> Diff: http://reviewboard.kde.org/r/4380/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thorsten
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]