[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Simple generator refactoring in
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2010-06-17 19:17:20
Message-ID: 20100617191720.15674.1544 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4365/#review6171
-----------------------------------------------------------

Ship it!


Looks good. Please commit

- Thorsten


On 2010-06-17 12:48:01, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4365/
> -----------------------------------------------------------
> 
> (Updated 2010-06-17 12:48:01)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This is simple refactoring in KoOdfLoadingContext. Generator QString type was \
> changed to enum. String is parsed only once when loading from meta.xml. 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/flake/KoOdfWorkaround.h 1138552 
> /trunk/koffice/libs/flake/KoOdfWorkaround.cpp 1138552 
> /trunk/koffice/libs/odf/KoOdfLoadingContext.h 1137787 
> /trunk/koffice/libs/odf/KoOdfLoadingContext.cpp 1137787 
> 
> Diff: http://reviewboard.kde.org/r/4365/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]