[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add a function to disable compression in KoStore
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-06-16 19:43:23
Message-ID: 20100616194323.15416.72980 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4328/#review6149
-----------------------------------------------------------

Ship it!


Good patch, some minor edits suggestions follow.


/trunk/koffice/libs/odf/KoStore.h
<http://reviewboard.kde.org/r/4328/#comment5771>

    Can you refer to the KZip::setCompression() API docs? They have some restrictions \
on when you can call this method which are going to apply here too.



/trunk/koffice/libs/odf/KoZipStore.cpp
<http://reviewboard.kde.org/r/4328/#comment5770>

    coding style; curly brace on same line as if.


- Thomas


On 2010-06-15 15:30:32, Cyrille Berger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4328/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 15:30:32)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch allows to enable/disable compression of files in a KoStore.
> 
> This patch is needed for implementing performance improvement on Krita file format.
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/odf/KoStore.h 1137311 
> /trunk/koffice/libs/odf/KoStore.cpp 1137311 
> /trunk/koffice/libs/odf/KoZipStore.h 1137311 
> /trunk/koffice/libs/odf/KoZipStore.cpp 1137311 
> 
> Diff: http://reviewboard.kde.org/r/4328/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cyrille
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]