[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Loop problem fix
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2010-06-15 14:48:09
Message-ID: 20100615144809.11931.84852 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4263/#review6121
-----------------------------------------------------------



/trunk/koffice/libs/flake/KoShape.cpp
<http://reviewboard.kde.org/r/4263/#comment5720>

    This should be a static method to make the method local to the file.


- Marijn


On 2010-06-15 14:38:14, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4263/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 14:38:14)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch solves possible loop problem when frame doesn't fit in layout, because \
> hasn't set width parameter. Default parameter had smaller width. Outer frame gets \
> width parameter from inner frame. If gets width from first inner one. Possibly it \
> can be changed to get width from inner frame with maximum width. (bug fix for: \
> https://bugs.kde.org/show_bug.cgi?id=238665) 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/flake/KoShape.cpp 1137787 
> 
> Diff: http://reviewboard.kde.org/r/4263/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]