'Re: Review Request: Implement loading and saving for text-on-shape'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Implement loading and saving for text-on-shape
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2010-06-15 9:26:19
Message-ID: 20100615092619.32480.73472 () localhost
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4322/#review6119
-----------------------------------------------------------

/trunk/koffice/filters/karbon/karbon1.x/Karbon1xImport.cpp
<http://reviewboard.kde.org/r/4322/#comment5714>

    Why the difference between EllipseShape and RectangleShape loading? EllipseShape \
does get a resourceManager, but RectangleShape doesn't?

/trunk/koffice/kword/part/kword.rc
<http://reviewboard.kde.org/r/4322/#comment5715>

    What is the point of changing the version number without having any other \
changes?

/trunk/koffice/libs/flake/tests/TestPathTool.cpp
<http://reviewboard.kde.org/r/4322/#comment5716>

    coding style: double ;; (also line 43 and 48)

/trunk/koffice/libs/flake/tests/TestPointMergeCommand.cpp
<http://reviewboard.kde.org/r/4322/#comment5717>

    also double ;; in this file

/trunk/koffice/libs/flake/tests/TestPointRemoveCommand.cpp
<http://reviewboard.kde.org/r/4322/#comment5718>

    and again here

/trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp
<http://reviewboard.kde.org/r/4322/#comment5719>

    there shouldn't be qDebug() calls in kde code

Also I'm not sure why in some unittess you create the KoResourceManager on the stack, \
and in some you create it on the heap (and then don't delete it).

- Marijn

On 2010-06-15 09:14:56, Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4322/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 09:14:56)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This builds on Thomas' text-on-shape patch and implements Thorsten's suggestions.
> 
> The path shape now inherits KoTextOnShapeContainer. Path shapes have to call \
> loadText/saveText (analogous to load/saveOdfAnnotations). It is not possible to use \
> the loadOdf/saveOdf of the text shape directly since that exports/saves a frame \
> around the text which is wrong.  
> There are still some interaction problems that need to be solved after merging this \
> patch with trunk. Notably: double-clicking always selects the text tool first, as \
> it is in OpenOffice, but that is not desirably for Karbon. Unless 0 is passed for \
> the KoResourceManager, all path shapes now have an embedded text shape. On adding \
> text to a newly created shape, the text is positiong wrong until the shape is \
> resized. This is something Thorsten wants to look into, as well as some other \
> issues. 
> 
> Diffs
> -----
> 
> /trunk/koffice/filters/karbon/karbon1.x/Karbon1xImport.cpp 1136404 
> /trunk/koffice/kword/part/KWView.cpp 1136404 
> /trunk/koffice/kword/part/kword.rc 1136404 
> /trunk/koffice/libs/flake/CMakeLists.txt 1136404 
> /trunk/koffice/libs/flake/KoConnectionShape.h 1136404 
> /trunk/koffice/libs/flake/KoConnectionShape.cpp 1136404 
> /trunk/koffice/libs/flake/KoConnectionShapeFactory.cpp 1136404 
> /trunk/koffice/libs/flake/KoConnectionShape_p.h 1136404 
> /trunk/koffice/libs/flake/KoParameterShape.h 1136404 
> /trunk/koffice/libs/flake/KoParameterShape.cpp 1136404 
> /trunk/koffice/libs/flake/KoParameterShape_p.h 1136404 
> /trunk/koffice/libs/flake/KoPathShape.h 1136404 
> /trunk/koffice/libs/flake/KoPathShape.cpp 1136404 
> /trunk/koffice/libs/flake/KoPathShapeFactory.h 1136404 
> /trunk/koffice/libs/flake/KoPathShapeFactory.cpp 1136404 
> /trunk/koffice/libs/flake/KoPathShape_p.h 1136404 
> /trunk/koffice/libs/flake/commands/KoParameterToPathCommand.cpp 1136404 
> /trunk/koffice/libs/flake/commands/KoPathCombineCommand.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestControlPointMoveCommand.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestPathShape.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestPathTool.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestPointMergeCommand.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestPointRemoveCommand.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestPointTypeCommand.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestRemoveSubpathCommand.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestResourceManager.cpp 1136404 
> /trunk/koffice/libs/flake/tests/TestSegmentTypeCommand.cpp 1136404 
> /trunk/koffice/libs/flake/tools/KoCreatePathTool.cpp 1136404 
> /trunk/koffice/libs/kotext/KoTextShapeContainerModel.h 1136404 
> /trunk/koffice/libs/kotext/KoTextShapeData.h 1136404 
> /trunk/koffice/libs/kotext/KoTextShapeData.cpp 1136404 
> /trunk/koffice/plugins/artistictextshape/ArtisticTextShape.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/ellipse/EllipseShape.h 1136404 
> /trunk/koffice/plugins/pathshapes/ellipse/EllipseShape.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/ellipse/EllipseShapeFactory.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.h 1136404 
> /trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp 1136404 \
>                 
> /trunk/koffice/plugins/pathshapes/rectangle/RectangleShape.h 1136404 
> /trunk/koffice/plugins/pathshapes/rectangle/RectangleShape.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/rectangle/RectangleShapeFactory.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/spiral/SpiralShape.h 1136404 
> /trunk/koffice/plugins/pathshapes/spiral/SpiralShape.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/spiral/SpiralShapeFactory.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/star/StarShape.h 1136404 
> /trunk/koffice/plugins/pathshapes/star/StarShape.cpp 1136404 
> /trunk/koffice/plugins/pathshapes/star/StarShapeFactory.cpp 1136404 
> 
> Diff: http://reviewboard.kde.org/r/4322/diff
> 
> 
> Testing
> -------
> 
> loaded and saved several test documents and tested interoperability with \
> OpenOffice. 
> 
> Thanks,
> 
> Boudewijn
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 