[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Enabling toggle grid functionality in the view
From:       "Srihari Prasad GV" <sri-hari () live ! com>
Date:       2010-06-14 6:10:50
Message-ID: 20100614061050.22490.7087 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3856/
-----------------------------------------------------------

(Updated 2010-06-14 06:10:50.472347)


Review request for KOffice.


Changes
-------


Hi there,

so nice that you put up a review. Important step :)
There are a couple of small issues, which should be fixed soon and then we can commit \
the fix.

As mentioned by Thorsten, your diff was made for the whole of koffice which is out of \
date. Please re-submit a patch of just the kspread dir.

Some more comments below.

Thanks!

    Tooltips don't use Book Case; so you should have just one uppercase char.  

    I think its not plural; in other words the user visible text should be: "Page \
Grid". 

      
    Only the active sheet?
    How does this work when you have more than one sheet?


Summary
-------

 Bug 141406 -  JJ: enable toggling grid lines visibility
I have added an option in the view menu and written toggle grid function which will \
call setShowGrid().The page was not rendering correctly so I have called the repaint \
function at the end.  


This addresses bug 141406.
    https://bugs.kde.org/show_bug.cgi?id=141406


Diffs (updated)
-----

  /trunk/koffice/kspread/kspread.rc 1136903 
  /trunk/koffice/kspread/kspread_readonly.rc 1136903 
  /trunk/koffice/kspread/part/View.h 1136903 
  /trunk/koffice/kspread/part/View.cpp 1136903 

Diff: http://reviewboard.kde.org/r/3856/diff


Testing
-------


Thanks,

Srihari

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]