'Re: Review Request: Kword drawing order fix'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kword drawing order fix
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-06-10 11:32:17
Message-ID: 20100610113217.17256.15331 () localhost
[Download RAW message or body]

> On 2010-06-09 22:20:32, Thomas Zander wrote:
> > > Problems with drawing order as it is now :
> > > 
> > > Header, footer and main text have the same ZIndex value and order in which
> > > they are drawn is random.
> > 
> > I don't understand why this is a problem. The header, footer and main text per \
> > definition do not overlap so their z-order is irrelevant. Could you explain why \
> > this is an issue for you? 
> > > Page background is drawn as background of main
> > > text and it is not possible to draw something behind main text.
> > 
> > This has a syntax error; or its a self conflicting sentence. We draw the \
> > background behind the text right now, so why are you saying its not possible to \
> > draw something while we do that. KoShape has special features for shape \
> > background and we use that. 
> > > compareShapeZIndex()function doesn't support "style:run-through" property,
> > > which in combination with "style:wrap" defines that anchored shape is
> > > behind text, inside text or in front text.
> > 
> > ok, thats a good reason. Thats the very first ever time I see this problem \
> > written down. Thanks for clarifying what you are working on :) What combination \
> > of properties allows a shape to be in front of a text? I only saw a document \
> > casper sent but that one was useless since it didn't actually use those odf \
> > properties. 
> > Last comment; why did you not use the suggestion I made in a separate mail thread \
> > where you asked for suggested way of solving the issue ? I suggested a solution \
> > that would only touch the text shape, this patch is *much* more involved. So I'd \
> > be very much interested why you didn't use that suggestion.
> 
> Matus Hanzes wrote:
> > I don't understand why this is a problem. The header, footer and main text per \
> > definition do not overlap so their z-order is irrelevant. Could you explain why \
> > this is an issue for  you?
> 
> Text can't overlap but objects anchored into it can.
> 
> Example
> If you anchor image inside footer and the properties are \
> "text:anchor-type="char"";"style:wrap="run-through"";"style:run-through="background"" \
> you can drag the image inside main text area.  
> Image should be drawn always behind main text but the current drawing order is \
> random. 
> > This has a syntax error; or its a self conflicting sentence. We draw the \
> > background behind the text right now, so why are you saying its not possible to \
> > draw something while we do  that. KoShape has special features for shape \
> > background and we use that.
> 
> The problem is that background is bind to main text and it is not possible to draw \
> something between them. 
> Example
> Drawing order with picture behind text now:
> 1 picture behind text
> 2 page background
> 3 main text
> Picture behind text will be hidden
> 
> Drawing order that I need: 
> 1 page background
> 2 picture behind text
> 3 main text
> 
> > Last comment; why did you not use the suggestion I made in a separate mail thread \
> > where you asked for suggested way of solving the issue ? I suggested a solution \
> > that would only  touch the text shape, this patch is *much* more involved. So I'd \
> > be very much interested why you didn't use that suggestion.
> 
> I thought that it is not relevant anymore because I and C. Boemann had some \
> questions but there was no response from you. 

> I thought that it is not relevant anymore because I and C. Boemann had some
> questions but there was no response from you.

Ehm, there were some tiny implementation details (use default z-index of very high or \
less high) that was opened up for question, how does that invalidate the whole \
suggestion? :(

If you don't want to follow a certain design I think its only reasonable to give a \
(technical) reasoning for why a different solution works better.  Why did you choose \
this solution instead of the solution that was suggested when you asked for feedback \
on your problem? If I think the much more maintainable solution of only changing one \
component instead of changing (/me counts) 4 components to work together is more \
useful I might want to replace your solution with a better one down the line. So at \
minimum give an explanation of why you choose this solution over the one I suggested.

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4173/#review6067
-----------------------------------------------------------

On 2010-06-07 12:31:47, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4173/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 12:31:47)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> KWOdfLoader
> Added support for loading of frame properties for objects anchored in header or \
> footer, but I am not sure it is the right way to do it. 
> KOshape
> Added support for something like layers, so that shape placed in lower layer are \
> drawn earlyer than shape in higher layer. 
> KWFrame
> Have added support for placing shapes in layers.
> 
> RunThrough-Backgrond is placed in layer -1.
> RunThrough-Foreground is placed in layer 1.
> All others runAround properties are placed in layer 0.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/CMakeLists.txt 1135394 
> trunk/koffice/kword/part/KWOdfLoader.cpp 1135394 
> trunk/koffice/kword/part/KWOdfSharedLoadingData.cpp 1135394 
> trunk/koffice/kword/part/KWPageBackground.h PRE-CREATION 
> trunk/koffice/kword/part/KWPageBackground.cpp PRE-CREATION 
> trunk/koffice/kword/part/KWord.h 1135394 
> trunk/koffice/kword/part/KWord.cpp 1135394 
> trunk/koffice/kword/part/frames/KWFrame.h 1135394 
> trunk/koffice/kword/part/frames/KWFrame.cpp 1135394 
> trunk/koffice/kword/part/frames/KWFrameLayout.h 1135394 
> trunk/koffice/kword/part/frames/KWFrameLayout.cpp 1135394 
> trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1135394 
> trunk/koffice/libs/flake/KoShape.h 1135394 
> trunk/koffice/libs/flake/KoShape.cpp 1135394 
> trunk/koffice/libs/flake/KoShape_p.h 1135394 
> 
> Diff: http://reviewboard.kde.org/r/4173/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 