[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kword drawing order fix
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-06-09 22:20:27
Message-ID: 20100609222027.21652.55554 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4173/#review6067
-----------------------------------------------------------


> Problems with drawing order as it is now :
> 
> Header, footer and main text have the same ZIndex value and order in which
> they are drawn is random.

I don't understand why this is a problem. The header, footer and main text per \
definition do not overlap so their z-order is irrelevant. Could you explain why this \
is an issue for you?

> Page background is drawn as background of main
> text and it is not possible to draw something behind main text.

This has a syntax error; or its a self conflicting sentence. We draw the background \
behind the text right now, so why are you saying its not possible to draw something \
while we do that. KoShape has special features for shape background and we use that.

> compareShapeZIndex()function doesn't support "style:run-through" property,
> which in combination with "style:wrap" defines that anchored shape is
> behind text, inside text or in front text.

ok, thats a good reason. Thats the very first ever time I see this problem written \
down. Thanks for clarifying what you are working on :) What combination of properties \
allows a shape to be in front of a text? I only saw a document casper sent but that \
one was useless since it didn't actually use those odf properties.

Last comment; why did you not use the suggestion I made in a separate mail thread \
where you asked for suggested way of solving the issue ? I suggested a solution that \
would only touch the text shape, this patch is *much* more involved. So I'd be very \
much interested why you didn't use that suggestion.

- Thomas


On 2010-06-07 12:31:47, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4173/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 12:31:47)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> KWOdfLoader
> Added support for loading of frame properties for objects anchored in header or \
> footer, but I am not sure it is the right way to do it. 
> KOshape
> Added support for something like layers, so that shape placed in lower layer are \
> drawn earlyer than shape in higher layer. 
> KWFrame
> Have added support for placing shapes in layers.
> 
> RunThrough-Backgrond is placed in layer -1.
> RunThrough-Foreground is placed in layer 1.
> All others runAround properties are placed in layer 0.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/CMakeLists.txt 1135394 
> trunk/koffice/kword/part/KWOdfLoader.cpp 1135394 
> trunk/koffice/kword/part/KWOdfSharedLoadingData.cpp 1135394 
> trunk/koffice/kword/part/KWPageBackground.h PRE-CREATION 
> trunk/koffice/kword/part/KWPageBackground.cpp PRE-CREATION 
> trunk/koffice/kword/part/KWord.h 1135394 
> trunk/koffice/kword/part/KWord.cpp 1135394 
> trunk/koffice/kword/part/frames/KWFrame.h 1135394 
> trunk/koffice/kword/part/frames/KWFrame.cpp 1135394 
> trunk/koffice/kword/part/frames/KWFrameLayout.h 1135394 
> trunk/koffice/kword/part/frames/KWFrameLayout.cpp 1135394 
> trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1135394 
> trunk/koffice/libs/flake/KoShape.h 1135394 
> trunk/koffice/libs/flake/KoShape.cpp 1135394 
> trunk/koffice/libs/flake/KoShape_p.h 1135394 
> 
> Diff: http://reviewboard.kde.org/r/4173/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]