[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Kword drawing order fix
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-06-07 13:50:16
Message-ID: 20100607135016.5939.40447 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4173/#review6013
-----------------------------------------------------------
> There is problem in my previous fix because page background is bind to text
> frame and it is not possible to draw something behind text frame.
>
> To fix it I have created separate frame for page background, which has the
> lowest zIndex and is drawn always first.
>
> I have tried to use KoShapeLayer as proposed, but I see no possibility how
> to use it with current kword data model. But maybe I have missed something
> so if someone has an idea how to do it lets discuss it in more detail.
There seems to be a slight confusion; the shapeLayer was not a suggestion to solve \
your problem. Your review request still needs an explanation of what it is you are \
fixing in the first place. What is wrong with the drawing order and what did you do \
to test this?
Changes this big require unit tests, so this is a great time to start writing them :)
Please
a) make sure unit tests do not regress (stop failing)
b) add new unit tests for the new functionality.
- Thomas
On 2010-06-07 12:31:47, Matus Hanzes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4173/
> -----------------------------------------------------------
>
> (Updated 2010-06-07 12:31:47)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> KWOdfLoader
> Added support for loading of frame properties for objects anchored in header or \
> footer, but I am not sure it is the right way to do it.
> KOshape
> Added support for something like layers, so that shape placed in lower layer are \
> drawn earlyer than shape in higher layer.
> KWFrame
> Have added support for placing shapes in layers.
>
> RunThrough-Backgrond is placed in layer -1.
> RunThrough-Foreground is placed in layer 1.
> All others runAround properties are placed in layer 0.
>
>
> Diffs
> -----
>
> trunk/koffice/kword/part/CMakeLists.txt 1135394
> trunk/koffice/kword/part/KWOdfLoader.cpp 1135394
> trunk/koffice/kword/part/KWOdfSharedLoadingData.cpp 1135394
> trunk/koffice/kword/part/KWPageBackground.h PRE-CREATION
> trunk/koffice/kword/part/KWPageBackground.cpp PRE-CREATION
> trunk/koffice/kword/part/KWord.h 1135394
> trunk/koffice/kword/part/KWord.cpp 1135394
> trunk/koffice/kword/part/frames/KWFrame.h 1135394
> trunk/koffice/kword/part/frames/KWFrame.cpp 1135394
> trunk/koffice/kword/part/frames/KWFrameLayout.h 1135394
> trunk/koffice/kword/part/frames/KWFrameLayout.cpp 1135394
> trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1135394
> trunk/koffice/libs/flake/KoShape.h 1135394
> trunk/koffice/libs/flake/KoShape.cpp 1135394
> trunk/koffice/libs/flake/KoShape_p.h 1135394
>
> Diff: http://reviewboard.kde.org/r/4173/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matus
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic