[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: patch for KwTextDocumentLayout::relayout
From:       Thomas Zander <zander () kde ! org>
Date:       2010-06-03 17:52:35
Message-ID: 201006031952.36035.zander () kde ! org
[Download RAW message or body]

On Thursday 3. June 2010 09.27.45 Boudewijn Rempt wrote:
> Here, dirtyFrames is cleared but never filled every time we encounter
> a frame that's not dirty before we've encountered the first dirty
> frame,

Its filled here;
  QList<KWFrame*> dirtyFrames = frames;
the following line only removes the value passed, it does not clear the list.
  dirtyFrames.removeAll(frame);
so that code looks correct to me.

> and foundADirtyOne is never set to true, so the last loop never
> executes.

Good catch! Fixed in svn.
-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]