[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kword drawing order fix
From:       "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date:       2010-06-01 12:30:41
Message-ID: 20100601123041.2915.4767 () localhost
[Download RAW message or body]



> On 2010-05-28 15:21:04, Thomas Zander wrote:
> > This sounds like introducing duplicate concepts where existing ones would likely \
> > be able to solve your problem.  Thinks like zIndex (KoShape) and KoShapeLayer \
> > have the same name and/or concepts. So I don't think this is the right approach.

I have tried to do the same functionality with help of KoShapeLayer but I don't have \
solution.

The problem is that all anchored shapes have already a parent.
And kword expects from anchored shape that his parent is header frame or main text \
frame or footer frame. When I assign new parent of type KoShapeLayer to anchored \
shape previous expectation wouldn't be fulfilled.

If you have some suggestion how to change the Kword shapes-parent model please \
explain it in more detail.


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4173/#review5900
-----------------------------------------------------------


On 2010-05-28 15:09:25, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4173/
> -----------------------------------------------------------
> 
> (Updated 2010-05-28 15:09:25)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> KWOdfLoader
> Added support for loading of frame properties for objects anchored in header or \
> footer, but I am not sure it is the right way to do it. 
> KOshape
> Added support for something like layers, so that shape placed in lower layer are \
> drawn earlyer than shape in higher layer. 
> KWFrame
> Have added support for placing shapes in layers.
> 
> RunThrough-Backgrond is placed in layer -1.
> RunThrough-Foreground is placed in layer 1.
> All others runAround properties are placed in layer 0.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWOdfLoader.cpp 1131612 
> trunk/koffice/kword/part/KWOdfSharedLoadingData.cpp 1131612 
> trunk/koffice/kword/part/KWord.h 1131612 
> trunk/koffice/kword/part/frames/KWFrame.h 1131612 
> trunk/koffice/kword/part/frames/KWFrame.cpp 1131612 
> trunk/koffice/libs/flake/KoShape.h 1131612 
> trunk/koffice/libs/flake/KoShape.cpp 1131612 
> trunk/koffice/libs/flake/KoShape_p.h 1131612 
> 
> Diff: http://reviewboard.kde.org/r/4173/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]