From koffice-devel  Fri May 28 17:13:58 2010
From: "Pavol Korinek" <pavol.korinek () ixonos ! com>
Date: Fri, 28 May 2010 17:13:58 +0000
To: koffice-devel
Subject: Review Request: master page style from tables
Message-Id: <20100528171358.23655.11262 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=127506683832128


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4175/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

This is patch to get master page style name from tables. It's analogous functionality as kword already has for paragraphs. Kword uses attribute master page style to append new page in layout. (Fact: page break is type of section break.) I've made tests with .doc files:
1. two pages, two sections, two paragraphs -> works fine
2. two pages, two sections, two tables     -> kword handle two tables as one ! we need to handle table end on section break
3. two pages, two sections, two tables and paragraph after first table -> problem kword add three pages instead of two
4. input file from bugzilla (https://bugs.kde.org/show_bug.cgi?id=239239, https://projects.maemo.org/bugzilla/show_bug.cgi?id=143065) -> patch doesn't solve the problem :-(

if I handle section break with adding empty paragraph with page break attribute, than input file (4.) was viewed right, but there's conflict with page break in layout.cpp based on master style names. It adds two pages instead one if I use (1.) :-(

Could you please check my patch ? I haven't reason why it doesn't work right also for tables as for paragraph. Maybe I missed something in layout how are tables layouted.


Diffs
-----

  /trunk/koffice/kword/part/KWDocument.cpp 1131562 
  /trunk/koffice/plugins/textshape/Layout.cpp 1131562 

Diff: http://reviewboard.kde.org/r/4175/diff


Testing
-------


Thanks,

Pavol

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel