[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: anchor-test-fail (was Re: koffice)
From: Thomas Zander <zander () kde ! org>
Date: 2010-05-28 14:45:44
Message-ID: 201005281645.44297.zander () kde ! org
[Download RAW message or body]
Matus, I have not heard anything about this anymore and the test shows there
still is a regression. Any ideas how to proceed?
On Thursday 27. May 2010 15.35.53 Thomas Zander wrote:
> re-sending, koffice-devel fell out somehow.
>
> On Thursday 27. May 2010 14.55.36 Matus wrote:
> > > -----Original Message-----
> > > From: Thomas Zander [mailto:zander@kde.org]
> > > Sent: 27. may 2010 9:55
> > >
> > > Did you run the kword unit tests before committing like I asked?
> >
> > Sorry I forgot.
> >
> > I looked on the test and the found the problem.
> >
> > The problem is in KWAnchorStrategy::checkState ln:85 when kword checks if
> > KWPageTextInfo is null.
> >
> > It seems that in TestDocumentLayout tests KWPageTextInfo is always null.
> >
> > So the tests are not valid any more.
>
> The KWPageTextInfo pointer being null is a valid state that should not
> crash.
>
> The unit test is correct and the return false being done is something that
> doesn't need to be done in a lot of cases which the unit test tests.
> So maybe you can fix the check in KWAnchorStrategy::checkState so the unit
> tests pass again?
--
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic