[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: libmso: support for compressed pictures (WMF/EMF
From:       "Matus Uzak" <matus.uzak () ixonos ! com>
Date:       2010-05-25 9:33:58
Message-ID: 20100525093358.1952.24913 () localhost
[Download RAW message or body]



> On 2010-05-25 08:39:20, Inge Wallin wrote:
> > trunk/koffice/filters/libmso/pictures.cpp, line 189
> > <http://reviewboard.kde.org/r/4128/diff/2/?file=27455#file27455line189>
> > 
> > Does this also save a reference to the picture in manifest.xml?

No, that's done by the corresponding handler, that is graphicshandler.cpp for DOC and \
PptToOdp.cpp for PPT.


> On 2010-05-25 08:39:20, Inge Wallin wrote:
> > trunk/koffice/filters/libmso/pictures.cpp, line 165
> > <http://reviewboard.kde.org/r/4128/diff/2/?file=27455#file27455line165>
> > 
> > I think it may be more efficient to first create a new 4 byte word, and then \
> > prepend it to the buffer.  I think that the prepend operation is an expensive one \
> > that moves all of the contents so it shouldn't be performed more times than \
> > necessary.

I agree, please check the new patch.


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4128/#review5849
-----------------------------------------------------------


On 2010-05-25 08:23:15, Matus Uzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4128/
> -----------------------------------------------------------
> 
> (Updated 2010-05-25 08:23:15)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Pictures in EMF and WMF format may be compressed by the DEFLATE algorithm.  Using \
> the qUncompress function to decompress the data.  
> 
> Diffs
> -----
> 
> trunk/koffice/filters/libmso/pictures.cpp 1130151 
> 
> Diff: http://reviewboard.kde.org/r/4128/diff
> 
> 
> Testing
> -------
> 
> Decompression output checked with the 'display' utility. The msword-odf filter \
> output tested with oowriter.   
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]