[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kspread getting creshed while inserting video
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2010-05-24 16:25:54
Message-ID: 20100524162554.15717.38724 () localhost
[Download RAW message or body]



> On 2010-05-06 11:08:38, Thorsten Zachmann wrote:
> > Mek is right. Sorry. Please commit and close the bug given above
> 
> Thorsten Zachmann wrote:
> Do you have an svn account so you can commit it or should I commit it for you?

I have committed the patch. Can you please close the review request?


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3897/#review5448
-----------------------------------------------------------


On 2010-05-06 10:33:36, Ajay Pundhir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3897/
> -----------------------------------------------------------
> 
> (Updated 2010-05-06 10:33:36)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Kspread is getting crashed while trying to insert a video in kspread. I just opened \
> a new spreadsheet and clicked on insert video, then I just did mouse clicked on \
> spreadsheet area. It get crashed. The problem was it was passing a null pointer in \
> createDefaultShape inside VideoShapeFactory. I put the check condition and now it \
> is working fine. 
> 
> Diffs
> -----
> 
> /trunk/koffice/plugins/videoshape/VideoShapeFactory.cpp 1123560 
> 
> Diff: http://reviewboard.kde.org/r/3897/diff
> 
> 
> Testing
> -------
> 
> I tested this bug and now we are able to insert all shapes successfully.
> 
> 
> Thanks,
> 
> Ajay
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]