[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/odf
From:       "C. Boemann" <cbo () boemann ! dk>
Date:       2010-05-24 11:16:29
Message-ID: 201005241316.29310.cbo () boemann ! dk
[Download RAW message or body]

On Monday 24 May 2010 13:10:49 Thomas Zander wrote:
> On Monday 24. May 2010 13.02.56 Inge Wallin wrote:
> > On Monday 24 May 2010 11:56:00 Thomas Zander wrote:
> > > SVN commit 1130040 by zander:
> > > 
> > > Make KoOdfNumberStyles into a namespace
> > > 
> > >  M  +27 -16    KoOdfNumberStyles.cpp
> > >  M  +11 -27    KoOdfNumberStyles.h
> > 
> > What's the thinking behind this rather limited namespace?  Wouldn't a
> > more general KoOdf namespace make more sense?  You wouldn't normally 
use
> > a namespace for just a few classes.
> 
> Probably grew like that over time; I'd be all in favor of doing an
> 
> hunk libs/odf/KoOdfNumberStyles.h 36
> -namespace KoOdfNumberStyles
> +namespace KoOdf
> 
> But that should likely be a review-request since that would involve
> changing the apps too.
This mail is just as good as far as I'm concerned. I'll approve.
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]