[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix "Text displayed at wrong place in this
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-22 9:16:12
Message-ID: 20100522091612.31393.76881 () localhost
[Download RAW message or body]



> On 2010-05-20 13:04:02, Thomas Zander wrote:
> > trunk/koffice/libs/kotext/KoTextAnchor.h, line 72
> > <http://reviewboard.kde.org/r/3699/diff/4/?file=27032#file27032line72>
> > 
> > What is the difference between TopOfPageContent and TopOfFrame ?
> > Same question for BottomOfFrame/BottomOfPageContent
> 
> Matus Hanzes wrote:
> It is the same when we have a shape anchor in main text.
> It is different when we have a shape anchor in header or footer.
> 
> TopOfPageContent anchors a shape always on top of main text frame and the \
> TopOfFrame anchors a shape on top of current frame. BottomOfPageContent anchors a \
> shape always on bottom of main text frame and the BottomOfFrame anchors a shape on \
> bottom of current frame. 
> 

Would be nice if you could add some more text to the enum values to explain that.


> On 2010-05-20 13:04:02, Thomas Zander wrote:
> > trunk/koffice/libs/kotext/KoTextAnchor.h, line 83
> > <http://reviewboard.kde.org/r/3699/diff/4/?file=27032#file27032line83>
> > 
> > Whats the difference between Left and LeftOfPage ?  Same with Right/RightOfPage.
> > 
> > And whats the difference between the above two and LeftOfPageContent ?
> 
> Matus Hanzes wrote:
> Left anchors a shape on frame left border and LeftOfPage anchors a shape on page \
> left border. Right anchors a shape on frame right border and RightOfPage anchors a \
> shape on page right border. 
> LeftOfPageContent/Left and RightOfPageContent/Right look like they are the same for \
> now. 
> 
> 
> 

I'm still not sure I get the difference between left border and page left border.
Does this mean it goes into the margin of the page?  Maybe good to explain this a bit \
better in the APi docs too.

Whats the idea behind the LeftOfPageContent/Left ones then?  If they are the same can \
they be merged for now?

If you can put up a last review with the issues I suggested fixed and clarified we \
probably are good to commit. :)


> On 2010-05-20 13:04:02, Thomas Zander wrote:
> > trunk/koffice/kword/part/frames/KWFrameLayout.cpp, line 278
> > <http://reviewboard.kde.org/r/3699/diff/4/?file=27030#file27030line278>
> > 
> > Header distance should be the empty space between the bottom of the header and \
> > the top of the main text, this change interprets it differently. Can you explain \
> > why?
> 
> Matus Hanzes wrote:
> Kword takes the header distance from <style:header-footer-properties fo:min-height>
> 
> Msword-odf filter and Open office understands it as the distance between header top \
> and main text top. 
> I can change it in msword-odf filter but not in open office.
> When we want to have compatible page layout with open office this change is needed.

Hmm, I see your point.  I'm not sure how the 'header-distance' is supposed to be \
saved into ODF as the svg:height should be used but is currently not. Anyway, not too \
important for anchors.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3699/#review5755
-----------------------------------------------------------


On 2010-05-18 14:32:15, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3699/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 14:32:15)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> To place draw objects properly in kword document I needed to add more support for \
> anchoring in kword.(style:vertical-pos,style:vertical-rel,style:horizontal-pos,style:vertical-rel)
>  I tried to make anchoring backward compatible.
> 
> Comments are welcome.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWPageStyle.h 1128171 
> trunk/koffice/kword/part/KWPageStyle.cpp 1128171 
> trunk/koffice/kword/part/KWPageStyle_p.h 1128171 
> trunk/koffice/kword/part/KWPageTextInfo.h 1128171 
> trunk/koffice/kword/part/KWPageTextInfo.cpp 1128171 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.h 1128171 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1128171 
> trunk/koffice/kword/part/frames/KWFrameLayout.cpp 1128171 
> trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1128171 
> trunk/koffice/libs/kotext/KoTextAnchor.h 1128171 
> trunk/koffice/libs/kotext/KoTextAnchor.cpp 1128171 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1128171 
> 
> Diff: http://reviewboard.kde.org/r/3699/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]