[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fixing a crash problem seen in lot of pptx files
From:       "Lassi Nieminen" <lassniem () gmail ! com>
Date:       2010-05-21 12:15:34
Message-ID: 20100521121534.3154.45074 () localhost
[Download RAW message or body]



> On 2010-05-20 14:35:48, Inge Wallin wrote:
> > It seems to me that this patch serves to hide a deeper problem.  Should it really \
> > be allowed that there is a shape being read but not a valid \
> > m_currentShapeProperties?  I'd like to know that before I put the "Ship it!" on \
> > this one.

I think the issue here might be that master slide reading is missing implementation, \
the real fix could be to implement them...which however might take some time, so \
perhaps this is ok as a temporary fix.


- Lassi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4072/#review5757
-----------------------------------------------------------


On 2010-05-20 13:57:38, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4072/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 13:57:38)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Its coming due to accessing null pointer.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h 1128862 
> 
> Diff: http://reviewboard.kde.org/r/4072/diff
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Amit
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]