[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix "Text displayed at wrong place in this
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-20 13:03:58
Message-ID: 20100520130358.947.83098 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3699/#review5755
-----------------------------------------------------------


The code looks really good, thanks :)
I'm having some questions about designs you made. Would be good if you can clear them \
up.

Also your patch currently looses the horizontal-rel and other related properties on a \
load+save, any plans to make that work properly?


trunk/koffice/kword/part/KWPageStyle.h
<http://reviewboard.kde.org/r/3699/#comment5397>

    Please rename those to not use abbreviations. (Min -> Minimum)



trunk/koffice/kword/part/KWPageTextInfo.h
<http://reviewboard.kde.org/r/3699/#comment5398>

    Please make const and don't return a reference;
      KWPage page() const;



trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp
<http://reviewboard.kde.org/r/3699/#comment5399>

    After a dynamic cast you probably want to check the output to not be null.



trunk/koffice/kword/part/frames/KWFrameLayout.cpp
<http://reviewboard.kde.org/r/3699/#comment5400>

    The 10 was there to make sure there is at least one line of text as otherwise it \
can shrink to be too small.  I think this line should therefore be use a qMax(10, \
page.pageStyle().headerMinHeight());



trunk/koffice/kword/part/frames/KWFrameLayout.cpp
<http://reviewboard.kde.org/r/3699/#comment5401>

    Header distance should be the empty space between the bottom of the header and \
the top of the main text, this change interprets it differently. Can you explain why?



trunk/koffice/libs/kotext/KoTextAnchor.h
<http://reviewboard.kde.org/r/3699/#comment5402>

    What is the difference between TopOfPageContent and TopOfFrame ?
    Same question for BottomOfFrame/BottomOfPageContent



trunk/koffice/libs/kotext/KoTextAnchor.h
<http://reviewboard.kde.org/r/3699/#comment5403>

    Whats the difference between Left and LeftOfPage ?  Same with Right/RightOfPage.
    
    And whats the difference between the above two and LeftOfPageContent ?


- Thomas


On 2010-05-18 14:32:15, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3699/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 14:32:15)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> To place draw objects properly in kword document I needed to add more support for \
> anchoring in kword.(style:vertical-pos,style:vertical-rel,style:horizontal-pos,style:vertical-rel)
>  I tried to make anchoring backward compatible.
> 
> Comments are welcome.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWPageStyle.h 1128171 
> trunk/koffice/kword/part/KWPageStyle.cpp 1128171 
> trunk/koffice/kword/part/KWPageStyle_p.h 1128171 
> trunk/koffice/kword/part/KWPageTextInfo.h 1128171 
> trunk/koffice/kword/part/KWPageTextInfo.cpp 1128171 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.h 1128171 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1128171 
> trunk/koffice/kword/part/frames/KWFrameLayout.cpp 1128171 
> trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1128171 
> trunk/koffice/libs/kotext/KoTextAnchor.h 1128171 
> trunk/koffice/libs/kotext/KoTextAnchor.cpp 1128171 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1128171 
> 
> Diff: http://reviewboard.kde.org/r/3699/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]