[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix "Table is displayed on the entire page of
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-20 11:29:34
Message-ID: 20100520112934.30533.28842 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4051/#review5752
-----------------------------------------------------------

Ship it!


excellent fix!

- Thomas


On 2010-05-19 13:07:25, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4051/
> -----------------------------------------------------------
> 
> (Updated 2010-05-19 13:07:25)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> There is a problem with line placing inside a table, because the layout places \
> lines outside shape. 
> The cause of this problem is inside Line::tryFit() when this function checks if the \
> first character fits inside line rectangle. When the line doesn't starts from left \
> border of shape and the width of line is small, than if statement is always true \
> and the line is moved down. 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1128171 
> 
> Diff: http://reviewboard.kde.org/r/4051/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]