[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add line numbers to KWord
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2010-05-20 9:31:51
Message-ID: 20100520093151.26920.6042 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3944/#review5749
-----------------------------------------------------------


Boud will redo this patch, as this one apparently lacked some changes.

- Inge


On 2010-05-10 14:03:04, Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3944/
> -----------------------------------------------------------
> 
> (Updated 2010-05-10 14:03:04)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds line numbers to KWord and the text shape.  It's quite large, and \
> the reason for that is partly that it's a complex addition, partly that it builds \
> on the endnotes patch.  I have tried hard to separate them, but it was very \
> difficult since they affect the same code. 
> So in the end I bet your collective pardon, and put this up here for review.  Feel \
> free to ignore the parts that are already commented on in the endnotes review. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/kotext/KoTextDocument.h 1124916 
> trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1124916 
> trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1124916 
> trunk/koffice/kword/part/KWOdfLoader.cpp 1124916 
> trunk/koffice/libs/kotext/KoTextDocument.cpp 1124916 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1124916 
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h 1124916 
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1124916 
> trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1124916 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.h 1124916 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1124916 
> trunk/koffice/libs/odf/CMakeLists.txt 1124916 
> trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.h PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.cpp PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfNotesConfiguration.h PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfNotesConfiguration.cpp PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfNumberDefinition.h PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfNumberDefinition.cpp PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfStylesReader.h 1124916 
> trunk/koffice/libs/odf/KoOdfStylesReader.cpp 1124916 
> trunk/koffice/plugins/textshape/Layout.h 1124916 
> trunk/koffice/plugins/textshape/Layout.cpp 1124916 
> trunk/koffice/plugins/textshape/TextShape.cpp 1124916 
> 
> Diff: http://reviewboard.kde.org/r/3944/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]