[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Triangle Pathshape for kivio
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2010-05-19 3:55:45
Message-ID: 20100519035545.15108.92477 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4014/#review5733
-----------------------------------------------------------


I totally agree that a triangle shape is a must have. However the way you have chosen \
is not correct. As written in my last post the star shape already supports a \
triangle. Your triangle will create invalid odf as you just added an unsupported tag \
draw:triangle. So the way to go to get a triangle shape in the add shape docker is to \
add a template for the StarShape that creates a triangle. In \
StarShapeFactory::StarShapeFactory(QObject *parent) there are already templates for \
e.g. a pentagon which should make it very simple to also add a triangle. All this \
without the need for new classes.

- Thorsten


On 2010-05-18 14:57:43, xeike wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4014/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 14:57:43)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Hi!
> 
> This is my first shape for kivio. It creates a triangle, you can rotate it fill it \
> with a colour and stretch as you can do with the other shapes.  
> This triangle has just three points, no handles and does not come with a widget. 
> 
> The Tar file contains a directory koffice/plugins/pathshapes/triangle/ with factory \
> and shape files, addes a png file and a diff to apply. This diff modifies \
> PathShapesPlugin.cpp and CMakeLists.txt. 
> Feel free to give me some feedback.
> 
> Eike
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/plugins/pathshapes/CMakeLists.txt 1128173 
> /trunk/koffice/plugins/pathshapes/PathShapesPlugin.cpp 1128173 
> /trunk/koffice/plugins/pathshapes/triangle/TriangleShape.h PRE-CREATION 
> /trunk/koffice/plugins/pathshapes/triangle/TriangleShape.cpp PRE-CREATION 
> /trunk/koffice/plugins/pathshapes/triangle/TriangleShapeFactory.h PRE-CREATION 
> /trunk/koffice/plugins/pathshapes/triangle/TriangleShapeFactory.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4014/diff
> 
> 
> Testing
> -------
> 
> Added some triangles, rotated and filled with colour. Stretched.
> 
> 
> Thanks,
> 
> xeike
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]