[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: msword-odf filter: parsing and processing of
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2010-05-18 14:07:00
Message-ID: 20100518140700.28244.8995 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4029/#review5716
-----------------------------------------------------------


I have checked now, and it seems that my talking about Qt was completely wrong.  Pole \
does in fact *not* depend on Qt.  So because of that, you can just commit it without \
any discussion.

- Inge


On 2010-05-18 11:54:27, Matus Uzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4029/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 11:54:27)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Patch description:
> 
> * The PictureHandler class has been removed. 
> * DrawingHandler class renamed into GraphicsHandler to reflect the corresponding \
>                 file name.  
> * Parsing (libmso) and processing of all MS-ODRAW content (floating and in-line \
>                 objects) is handled by the GraphicsHandler.
> * The old wv2 code taking care of parsing of in-line objects has been marked as \
> obsolete.  I left it there, that anyone can check it prior to it's removal. 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kword/msword-odf/document.h 1126239 
> trunk/koffice/filters/kword/msword-odf/document.cpp 1126239 
> trunk/koffice/filters/kword/msword-odf/graphicshandler.h 1126239 
> trunk/koffice/filters/kword/msword-odf/graphicshandler.cpp 1126239 
> trunk/koffice/filters/kword/msword-odf/mswordodfimport.cpp 1126239 
> trunk/koffice/filters/kword/msword-odf/texthandler.h 1126239 
> trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1126239 
> trunk/koffice/filters/kword/msword-odf/wv2/src/graphics.h 1126239 
> trunk/koffice/filters/kword/msword-odf/wv2/src/graphics.cpp 1126239 
> trunk/koffice/filters/kword/msword-odf/wv2/src/handlers.h 1126239 
> trunk/koffice/filters/kword/msword-odf/wv2/src/handlers.cpp 1126239 
> trunk/koffice/filters/kword/msword-odf/wv2/src/parser.h 1126239 
> trunk/koffice/filters/kword/msword-odf/wv2/src/parser.cpp 1126239 
> trunk/koffice/filters/kword/msword-odf/wv2/src/parser9x.cpp 1126239 
> trunk/koffice/filters/kword/msword-odf/wv2/src/word97_generated.h 1126239 
> trunk/koffice/filters/libmso/drawstyle.h 1126239 
> trunk/koffice/filters/libmso/drawstyle.cpp 1126239 
> 
> Diff: http://reviewboard.kde.org/r/4029/diff
> 
> 
> Testing
> -------
> 
> Parsing and processing of in-line objects has been tested. 
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]